MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-27 10:03:11 +07:00
Code Issues Packages Projects Releases Wiki Activity

IG: enable inspection by default, at INFORMATION level

Browse Source 
"Unnecessarily qualified inner class access" inspection
This commit is contained in:
Bas Leijdekkers
2018-05-01 22:33:05 +02:00
parent efc1516257
commit fbe9ffd07b
3 changed files with 10 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files
plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/style/UnnecessarilyQualifiedInnerClassAccessInspection.java
+7 -7
View File
@@ -105,7 +105,7 @@ public class UnnecessarilyQualifiedInnerClassAccessInspection extends BaseInspec
return new UnnecessarilyQualifiedInnerClassAccessVisitor();
}
private static boolean isReferenceToTarget(String referenceText, @NotNull PsiClass target, PsiElement context) {
static boolean isReferenceToTarget(String referenceText, @NotNull PsiClass target, PsiElement context) {
final PsiJavaCodeReferenceElement reference =
JavaPsiFacade.getElementFactory(target.getProject()).createReferenceFromText(referenceText, context);
final JavaResolveResult[] results = reference.multiResolve(false);
@@ -151,13 +151,13 @@ public class UnnecessarilyQualifiedInnerClassAccessInspection extends BaseInspec
return;
}
final PsiElement brace = referenceClass.getLBrace();
ProblemHighlightType highlightType = ProblemHighlightType.LIKE_UNUSED_SYMBOL;
if (!referenceClass.equals(qualifierTarget) || brace != null && brace.getTextOffset() > reference.getTextOffset()) {
if (ignoreReferencesNeedingImport &&
(PsiTreeUtil.isAncestor(referenceClass, qualifierTarget,
true) ||
!PsiTreeUtil.isAncestor(qualifierTarget,
referenceClass, true))) {
return;
(PsiTreeUtil.isAncestor(referenceClass, qualifierTarget, true) ||
!PsiTreeUtil.isAncestor(qualifierTarget, referenceClass, true))) {
if (!isOnTheFly()) return;
highlightType = ProblemHighlightType.INFORMATION;
}
}
final PsiElement target = reference.resolve();
@@ -176,7 +176,7 @@ public class UnnecessarilyQualifiedInnerClassAccessInspection extends BaseInspec
if (!isReferenceToTarget(shortName, aClass, reference)) {
return;
}
registerError(qualifier, ProblemHighlightType.LIKE_UNUSED_SYMBOL, aClass);
registerError(qualifier, highlightType, aClass);
}
@Override
plugins/InspectionGadgets/src/META-INF/InspectionGadgets.xml
+1 -1
View File
@@ -2387,7 +2387,7 @@
level="WARNING" implementationClass="com.siyeh.ig.style.TypeParameterExtendsObjectInspection"/>
<localInspection groupPath="Java" language="JAVA" shortName="UnnecessarilyQualifiedInnerClassAccess" bundle="com.siyeh.InspectionGadgetsBundle"
key="unnecessarily.qualified.inner.class.access.display.name" groupBundle="messages.InspectionsBundle"
groupKey="group.names.code.style.issues" enabledByDefault="false" level="WARNING" cleanupTool="true"
groupKey="group.names.code.style.issues" enabledByDefault="true" level="INFORMATION" cleanupTool="true"
implementationClass="com.siyeh.ig.style.UnnecessarilyQualifiedInnerClassAccessInspection"/>
<localInspection groupPath="Java" language="JAVA" shortName="UnnecessarilyQualifiedStaticUsage" bundle="com.siyeh.InspectionGadgetsBundle"
key="unnecessarily.qualified.static.usage.display.name" groupBundle="messages.InspectionsBundle"
plugins/InspectionGadgets/testsrc/com/siyeh/ig/fixes/style/UnnecessarilyQualifiedInnerClassAccessFixTest.java
+2 -2
View File
@@ -10,7 +10,7 @@ public class UnnecessarilyQualifiedInnerClassAccessFixTest extends IGQuickFixesT
public void testRemoveQualifier() {
doTest("Remove qualifier",
"class X {\n" +
" X<caret>/*1*/./*2*/Y foo;\n" +
" /**/X/*1*/./*2*/Y foo;\n" +
" \n" +
" class Y{}\n" +
"}",
@@ -27,7 +27,7 @@ public class UnnecessarilyQualifiedInnerClassAccessFixTest extends IGQuickFixesT
doTest("Remove qualifier",
"package p;\n" +
"import java.util.List;\n" +
"abstract class X implements List<<caret>X.Y> {\n" +
"abstract class X implements List</**/X.Y> {\n" +
" class Y{}\n" +
"}",