MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-27 10:03:11 +07:00
Code Issues Packages Projects Releases Wiki Activity

Disabled compatiblity inspection for backported 'enum' (PY-19486)

Browse Source 
We still have false negative for not mentioning 'enum34' in
requrements.txt.
This commit is contained in:
Andrey Vlasovskikh
2016-07-29 19:09:05 +03:00
parent 02bee28aa5
commit fbb2b5a0fa
3 changed files with 13 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
python/src/com/jetbrains/python/inspections/PyCompatibilityInspection.java
+7 -2
View File
@@ -60,6 +60,10 @@ import java.util.List;
* Inspection to detect code incompatibility with python versions
*/
public class PyCompatibilityInspection extends PyInspection {
public static List<String> BACKPORTED_PACKAGES = ImmutableList.<String>builder()
.add("enum")
.build();
public static final int LATEST_INSPECTION_VERSION = 1;
public static final List<LanguageLevel> DEFAULT_PYTHON_VERSIONS = ImmutableList.of(LanguageLevel.PYTHON27, LanguageLevel.getLatest());
@@ -244,7 +248,7 @@ public class PyCompatibilityInspection extends PyInspection {
final QualifiedName qName = importElement.getImportedQName();
if (qName != null && !qName.matches("builtins") && !qName.matches("__builtin__")) {
moduleName = qName.toString();
if (UnsupportedFeaturesUtil.MODULES.get(languageLevel).contains(moduleName)) {
if (UnsupportedFeaturesUtil.MODULES.get(languageLevel).contains(moduleName) && !BACKPORTED_PACKAGES.contains(moduleName)) {
len = appendLanguageLevel(message, len, languageLevel);
}
}
@@ -263,7 +267,8 @@ public class PyCompatibilityInspection extends PyInspection {
if (name != null) {
for (int i = 0; i != myVersionsToProcess.size(); ++i) {
LanguageLevel languageLevel = myVersionsToProcess.get(i);
if (UnsupportedFeaturesUtil.MODULES.get(languageLevel).contains(name.toString())) {
final String moduleName = name.toString();
if (UnsupportedFeaturesUtil.MODULES.get(languageLevel).contains(moduleName) && !BACKPORTED_PACKAGES.contains(moduleName)) {
len = appendLanguageLevel(message, len, languageLevel);
}
}
python/testData/inspections/PyCompatibilityInspection/backportedEnum.py
+1
View File
@@ -0,0 +1 @@
import enum
python/testSrc/com/jetbrains/python/inspections/PyCompatibilityInspectionTest.java
+5
View File
@@ -176,6 +176,11 @@ public class PyCompatibilityInspectionTest extends PyTestCase {
doTest();
}
// PY-19486
public void testBackportedEnum() {
doTest();
}
private void doTest(@NotNull LanguageLevel level) {
runWithLanguageLevel(level, this::doTest);
}