MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-27 10:03:11 +07:00
Code Issues Packages Projects Releases Wiki Activity

[plugin model] provide a way to automatically add newly extracted content modules to dependencies of existing plugins (IJPL-188866)

Browse Source 
'contentModulesExtractedInCorePluginWhichCanBeUsedFromExternalPlugins' property is introduced to allow extracting new content modules from the core platform without breaking compatibility with external plugins.
Actual values and a test for the new behavior will be added in next commits.

GitOrigin-RevId: 22bbc3874dfad79f69196193dff03eff0a428ac5
This commit is contained in:
Nikolay Chashnikov
2025-05-27 18:36:47 +00:00
committed by intellij-monorepo-bot
parent 8842961634
commit facf998a06
1 changed files with 18 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
platform/core-impl/src/com/intellij/ide/plugins/ModulesWithDependencies.kt
+18 -1
View File
@@ -170,12 +170,22 @@ private val knownNotFullyMigratedPluginIds: Set<String> = hashSetOf(
"com.jetbrains.pycharm.ds.customization",
)
/**
* Specifies the list of content modules which was recently extracted from the main module of the core plugin and may have external usages.
* Since such modules were loaded by the core classloader before, it wasn't necessary to specify any dependencies to use classes from them.
* To avoid breaking compatibility, dependencies on these modules are automatically added to plugins which define dependency on the platform using
* `<depends>com.intellij.modules.platform</depends` or `<depends>com.intellij.modules.lang</depends` tags.
*/
private val contentModulesExtractedInCorePluginWhichCanBeUsedFromExternalPlugins = listOf<String>(
)
private fun collectDirectDependenciesInOldFormat(rootDescriptor: IdeaPluginDescriptorImpl,
idMap: Map<String, PluginModuleDescriptor>,
dependenciesCollector: MutableSet<PluginModuleDescriptor>) {
for (dependency in rootDescriptor.dependencies) {
// check for missing optional dependency
val dep = idMap.get(dependency.pluginId.idString) ?: continue
val dependencyPluginId = dependency.pluginId.idString
val dep = idMap.get(dependencyPluginId) ?: continue
if (dep.pluginId != PluginManagerCore.CORE_ID || dep is ContentModuleDescriptor) {
// ultimate plugin it is combined plugin, where some included XML can define dependency on ultimate explicitly and for now not clear,
// can be such requirements removed or not
@@ -191,6 +201,13 @@ private fun collectDirectDependenciesInOldFormat(rootDescriptor: IdeaPluginDescr
dependenciesCollector.add(dep)
}
}
if (dependencyPluginId == "com.intellij.modules.platform" || dependencyPluginId == "com.intellij.modules.lang") {
for (contentModuleName in contentModulesExtractedInCorePluginWhichCanBeUsedFromExternalPlugins) {
idMap.get(contentModuleName)?.let {
dependenciesCollector.add(it)
}
}
}
if (knownNotFullyMigratedPluginIds.contains(rootDescriptor.pluginId.idString)) {
dependenciesCollector.addAll(idMap.get(PluginManagerCore.CORE_ID.idString)!!.contentModules)