MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-27 10:03:11 +07:00
Code Issues Packages Projects Releases Wiki Activity

[completion] IJPL-207762 cleanup MethodParenthesesHandler

Browse Source 
GitOrigin-RevId: 7b3fca656a463fa480c7158da1fb2123bf43e3b4
This commit is contained in:
Max Medvedev
2025-10-12 11:39:37 +00:00
committed by intellij-monorepo-bot
parent ffac8155cf
commit f98e786878
1 changed files with 7 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
java/openapi/src/com/intellij/codeInsight/completion/util/MethodParenthesesHandler.java
+7 -6
View File
@@ -1,4 +1,4 @@
// Copyright 2000-2024 JetBrains s.r.o. and contributors. Use of this source code is governed by the Apache 2.0 license.
// Copyright 2000-2025 JetBrains s.r.o. and contributors. Use of this source code is governed by the Apache 2.0 license.
package com.intellij.codeInsight.completion.util;
import com.intellij.codeInsight.completion.InsertionContext;
@@ -14,19 +14,19 @@ public class MethodParenthesesHandler extends ParenthesesInsertHandler<LookupEle
private final PsiMethod myMethod;
private final boolean myOverloadsMatter;
public MethodParenthesesHandler(final PsiMethod method, boolean overloadsMatter) {
public MethodParenthesesHandler(@NotNull PsiMethod method, boolean overloadsMatter) {
myMethod = method;
myOverloadsMatter = overloadsMatter;
}
@Override
protected boolean placeCaretInsideParentheses(final InsertionContext context, final LookupElement item) {
protected boolean placeCaretInsideParentheses(InsertionContext context, LookupElement item) {
return myOverloadsMatter
? overloadsHaveParameters(context.getElements(), myMethod) != ThreeState.NO
: !myMethod.getParameterList().isEmpty();
}
public static ThreeState overloadsHaveParameters(LookupElement[] allItems, PsiMethod method) {
public static @NotNull ThreeState overloadsHaveParameters(@NotNull LookupElement @NotNull [] allItems, @NotNull PsiMethod method) {
List<PsiMethod> overloads = JBIterable.of(allItems)
.map(LookupElement::getPsiElement)
.filter(PsiMethod.class)
@@ -35,13 +35,14 @@ public class MethodParenthesesHandler extends ParenthesesInsertHandler<LookupEle
return overloads.isEmpty() ? ThreeState.fromBoolean(!method.getParameterList().isEmpty()) : hasParameters(overloads);
}
public static @NotNull ThreeState hasParameters(List<PsiMethod> methods) {
public static @NotNull ThreeState hasParameters(@NotNull List<PsiMethod> methods) {
boolean hasEmpty = methods.isEmpty();
boolean hasNonEmpty = false;
for (PsiMethod method : methods) {
if (!method.getParameterList().isEmpty()) {
hasNonEmpty = true;
} else {
}
else {
hasEmpty = true;
}
}