IDEA-19372: Refactoring: Extract .tag file for static piece of JSP

java/jsp-base-openapi/src/com/intellij/psi/jsp/BaseJspFile.java

@@ -32,7 +32,7 @@ public interface BaseJspFile extends XmlFile {
   boolean isTagPage();
 
   XmlTag[] getDirectiveTags(JspDirectiveKind directiveKind, final boolean searchInIncludes);
-  XmlTag createDirective(XmlTag context, JspDirectiveKind page);
+  XmlTag createDirective(XmlTag context, JspDirectiveKind directiveKind);
 
   PsiFile getBaseLanguageRoot();
   /**
@@ -43,4 +43,4 @@ public interface BaseJspFile extends XmlFile {
 
   @NotNull
   JspxFileViewProvider getViewProvider();
-}
+}

platform/platform-api/src/com/intellij/openapi/vfs/VfsUtil.java

@@ -658,8 +658,8 @@ public class VfsUtil {
   }
 
   @Nullable
-  public static VirtualFile createDirectoryIfMissing(@NotNull String dir) throws IOException {
-    return doCreateDirectoriesIfMissing(FileUtil.toSystemIndependentName(dir));
+  public static VirtualFile createDirectoryIfMissing(@NotNull String directoryPath) throws IOException {
+    return doCreateDirectoriesIfMissing(FileUtil.toSystemIndependentName(directoryPath));
   }
 
   private static VirtualFile doCreateDirectoriesIfMissing(String dir) throws IOException {

platform/testFramework/src/com/intellij/testFramework/fixtures/CodeInsightFixtureTestCase.java

@@ -19,6 +19,7 @@ import com.intellij.openapi.application.PathManager;
 import com.intellij.openapi.editor.Editor;
 import com.intellij.openapi.module.Module;
 import com.intellij.openapi.project.Project;
+import com.intellij.psi.PsiFile;
 import com.intellij.testFramework.UsefulTestCase;
 import com.intellij.testFramework.builders.EmptyModuleFixtureBuilder;
 import org.jetbrains.annotations.NonNls;
@@ -83,4 +84,8 @@ public abstract class CodeInsightFixtureTestCase extends UsefulTestCase {
   protected Editor getEditor() {
     return myFixture.getEditor();
   }
+
+  protected PsiFile getFile() {
+    return myFixture.getFile();
+  }
 }

platform/testFramework/src/com/intellij/testFramework/fixtures/impl/CodeInsightTestFixtureImpl.java

@@ -185,7 +185,7 @@ public class CodeInsightTestFixtureImpl extends BaseFixture implements CodeInsig
           FileUtil.copy(fromFile, destFile);
         }
         catch (IOException e) {
-          throw new RuntimeException(e);
+          throw new RuntimeException("Cannot copy " + fromFile + " to " + destFile, e);
         }
       }
     }

xml/impl/src/com/intellij/xml/util/XmlUtil.java

@@ -190,12 +190,17 @@ public class XmlUtil {
     return null;
   }
 
-  @Nullable
-  public static String findNamespacePrefixByURI(XmlFile file, @NonNls String uri) {
+  @SuppressWarnings({"ConstantConditions"})
+  public static XmlTag getRootTag(XmlFile file) {
     if (file == null) return null;
     final XmlDocument document = file.getDocument();
     if (document == null) return null;
-    final XmlTag tag = document.getRootTag();
+    return document.getRootTag();
+  }
+
+  @Nullable
+  public static String findNamespacePrefixByURI(XmlFile file, @NonNls String uri) {
+    final XmlTag tag = getRootTag(file);
     if (tag == null) return null;
 
     for (XmlAttribute attribute : tag.getAttributes()) {