MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-27 10:03:11 +07:00
Code Issues Packages Projects Releases Wiki Activity

Highlight predefined assignment targets, too, not only references.

Browse Source
This commit is contained in:
Dmitry Cheryasov
2010-05-25 18:04:49 +03:00
parent d9106365ba
commit f5c4a5c60b
1 changed files with 36 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files
python/src/com/jetbrains/python/validation/PyBuiltinAnnotator.java
+36 -21
View File
@@ -7,10 +7,7 @@ import com.intellij.psi.ResolveResult;
import com.jetbrains.python.PyHighlighter;
import com.jetbrains.python.PyNames;
import com.jetbrains.python.PyTokenTypes;
import com.jetbrains.python.psi.PyClass;
import com.jetbrains.python.psi.PyDecorator;
import com.jetbrains.python.psi.PyReferenceExpression;
import com.jetbrains.python.psi.PyUtil;
import com.jetbrains.python.psi.*;
import com.jetbrains.python.psi.impl.PyBuiltinCache;
/**
@@ -23,23 +20,8 @@ public class PyBuiltinAnnotator extends PyAnnotator {
public void visitPyReferenceExpression(PyReferenceExpression node) {
final String name = node.getName();
if (name == null) return;
if (PyNames.UnderscoredAttributes.contains(name) || PyNames.BuiltinMethods.containsKey(name)) {
// things like __len__
if (
(node.getQualifier() != null) // foo.__len__
|| (PyUtil.getConcealingParent(node) instanceof PyClass) // class Foo: ... __len__ = myLenImpl
) {
final ASTNode astNode = node.getNode();
if (astNode != null) {
ASTNode tgt = astNode.findChildByType(PyTokenTypes.IDENTIFIER); // only the id, not all qualifiers subtree
if (tgt != null) {
Annotation ann = getHolder().createInfoAnnotation(tgt, null);
ann.setTextAttributes(PyHighlighter.PY_PREDEFINED_USAGE);
}
}
}
}
else if (node.getQualifier() == null) {
boolean highlighted_as_attribute = highlightAsAttribute(node, name);
if (! highlighted_as_attribute && node.getQualifier() == null) {
// things like len()
ResolveResult[] resolved = node.getReference().multiResolve(false); // constructors, etc may give multiple results...
if (resolved.length > 0) {
@@ -57,4 +39,37 @@ public class PyBuiltinAnnotator extends PyAnnotator {
}
}
@Override
public void visitPyTargetExpression(PyTargetExpression node) {
final String name = node.getName();
if (name == null) return;
highlightAsAttribute(node, name);
}
/**
* Try to highlight a node as a class attribute.
* @param node what to work with
* @return true iff the node was highlighted.
*/
private boolean highlightAsAttribute(PyQualifiedExpression node, String name) {
if (PyNames.UnderscoredAttributes.contains(name) || PyNames.BuiltinMethods.containsKey(name)) {
// things like __len__
if (
(node.getQualifier() != null) // foo.__len__
|| (PyUtil.getConcealingParent(node) instanceof PyClass) // class Foo: ... __len__ = myLenImpl
) {
final ASTNode astNode = node.getNode();
if (astNode != null) {
ASTNode tgt = astNode.findChildByType(PyTokenTypes.IDENTIFIER); // only the id, not all qualifiers subtree
if (tgt != null) {
Annotation ann = getHolder().createInfoAnnotation(tgt, null);
ann.setTextAttributes(PyHighlighter.PY_PREDEFINED_USAGE);
}
}
}
return false;
}
return true;
}
}