MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-27 10:03:11 +07:00
Code Issues Packages Projects Releases Wiki Activity

[vfs] IJPL-224842 add more diagnostics

Browse Source 
GitOrigin-RevId: 64a262c07788df815b0bc901fa9d72a0be668c0b
This commit is contained in:
Ruslan Cheremin
2025-12-23 20:31:41 +00:00
committed by intellij-monorepo-bot
parent cdcf64cef1
commit f43c6f3ed0
1 changed files with 9 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
platform/platform-impl/src/com/intellij/openapi/vfs/newvfs/persistent/FSRecordsImpl.java
+9 -6
View File
@@ -915,9 +915,9 @@ public final class FSRecordsImpl implements Closeable {
fileRecordLock.lockForHierarchyUpdate(maxId);
try {
try {
ListResult firstParentChildren = loadChildrenUnderRecordLock(fromParentId);
ListResult fromParentChildrenWithoutChildMoved = firstParentChildren.remove(childToMoveId);
if (fromParentChildrenWithoutChildMoved == firstParentChildren) {
ListResult fromParentChildren = loadChildrenUnderRecordLock(fromParentId);
ListResult fromParentChildrenWithoutChildMoved = fromParentChildren.remove(childToMoveId);
if (fromParentChildrenWithoutChildMoved == fromParentChildren) {
//RC: this means childToMove doesn't present among fromParent's children. It seems natural to fail move
// procedure in this case by throwing IllegalArgumentException, because there is definitely something
// wrong with arguments supplied. But the legacy version of this code didn't fail -- it proceeds
@@ -940,9 +940,12 @@ public final class FSRecordsImpl implements Closeable {
// is an error in params supplied, and it should be resolved
String childToMoveName = getNameByNameId(childToMoveNameId);
throw new IllegalArgumentException(
"Can't move child(#" + childToMoveId + ", name='" + childToMoveName + "') " +
"from parent(" + fromParentId + ") to (" + toParentId + "): " +
"toParent already has a child with same name -- " + alreadyExistingChild);
"Can't move child(#" + childToMoveId + ", name='" + childToMoveName + "', nameId=" + childToMoveNameId + "), " +
"parent (" + fromParentId + " -> " + toParentId + "): " +
"new parent already has a child with same name (=" + alreadyExistingChild + ")\n" +
"fromParent.children=" + fromParentChildren + "\n" +
"toParent.children=" + toParentChildren
);
}
ListResult toParentChildrenUpdated = toParentChildren.insert(