MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-27 10:03:11 +07:00
Code Issues Packages Projects Releases Wiki Activity

cachedValue should cache wisely

Browse Source
This commit is contained in:
peter
2011-03-23 16:21:52 +01:00
parent 575e78a3c9
commit f3f444a188
1 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
platform/platform-impl/src/com/intellij/util/CachedValueBase.java
+7 -7
View File
@@ -19,9 +19,7 @@ import com.intellij.openapi.Disposable;
import com.intellij.openapi.diagnostic.Logger;
import com.intellij.openapi.editor.Document;
import com.intellij.openapi.project.Project;
import com.intellij.openapi.util.Disposer;
import com.intellij.openapi.util.ModificationTracker;
import com.intellij.openapi.util.Ref;
import com.intellij.openapi.util.*;
import com.intellij.psi.util.CachedValueProvider;
import com.intellij.reference.SoftReference;
import gnu.trove.TLongArrayList;
@@ -76,9 +74,6 @@ public abstract class CachedValueBase<T> {
myData = null;
}
public void setDataLocked(boolean value) {
}
public boolean hasUpToDateValue() {
return getUpToDateOrNull(false) != null;
}
@@ -186,10 +181,15 @@ public abstract class CachedValueBase<T> {
return value == ObjectUtils.NULL ? null : value;
}
RecursionGuard.StackStamp stamp = RecursionManager.createGuard("cachedValue").markStack();
// compute outside lock to avoid deadlock
CachedValueProvider.Result<T> result = doCompute(param);
return setValue(result);
if (stamp.mayCacheNow()) {
return setValue(result);
}
return result == null ? null : result.getValue();
}
protected abstract <P> CachedValueProvider.Result<T> doCompute(P param);