switch expression: inference for result expression fixed; more testdata on overload resolution

This commit is contained in:
Anna.Kozlova
2018-11-20 10:56:11 +01:00
parent 1dbac8c385
commit f32caada92
3 changed files with 27 additions and 1 deletions
@@ -722,6 +722,7 @@ public class LambdaUtil {
PsiExpressionList.class,
PsiLambdaExpression.class,
PsiConditionalExpression.class,
PsiSwitchExpression.class,
PsiCodeBlock.class,
PsiCall.class);
while (true) {
@@ -750,7 +751,7 @@ public class LambdaUtil {
}
}
if (parent instanceof PsiConditionalExpression && !PsiPolyExpressionUtil.isPolyExpression((PsiExpression)parent)) {
if ((parent instanceof PsiConditionalExpression || parent instanceof PsiSwitchExpression) && !PsiPolyExpressionUtil.isPolyExpression((PsiExpression)parent)) {
break;
}
@@ -3,6 +3,7 @@ package com.intellij.psi.impl.source.resolve.graphInference;
import com.intellij.psi.*;
import com.intellij.psi.infos.MethodCandidateInfo;
import com.intellij.psi.util.PsiTreeUtil;
import com.intellij.psi.util.PsiUtil;
import com.intellij.psi.util.TypeConversionUtil;
import org.jetbrains.annotations.NotNull;
@@ -124,9 +125,17 @@ public class PsiPolyExpressionUtil {
return context instanceof PsiExpressionList ||
context instanceof PsiArrayInitializerExpression ||
context instanceof PsiConditionalExpression && (expr instanceof PsiCallExpression || isPolyExpression((PsiExpression)context)) ||
isSwitchExpressionAssignmentOrInvocationContext(expr) ||
isAssignmentContext(expr, context);
}
private static boolean isSwitchExpressionAssignmentOrInvocationContext(PsiExpression expr) {
PsiSwitchExpression switchExpression = PsiTreeUtil.getParentOfType(expr, PsiSwitchExpression.class);
return switchExpression != null &&
PsiUtil.getSwitchResultExpressions(switchExpression).contains(expr) &&
isInAssignmentOrInvocationContext(switchExpression);
}
private static boolean isAssignmentContext(PsiExpression expr, PsiElement context) {
return PsiUtil.isCondition(expr, context) ||
context instanceof PsiReturnStatement ||
@@ -1,11 +1,27 @@
import java.util.function.*;
class MyTest {
<T> T foo(T t) {
return t;
}
<T> T foo(Supplier<T> t) {
return t.get();
}
<T> T foo(IntSupplier t) {
return null;
}
static <K> K bar() {
return null;
}
void m(int i) {
String s = foo(switch (i) {default -> "str";});
String s1 = <error descr="Incompatible types. Required String but 'foo' was inferred to T:
no instance(s) of type variable(s) exist so that Object conforms to String">foo(switch (i) {case 1 -> new Object(); default -> "str";});</error>
String s2 = foo(() -> switch (i) {
default -> "str";
});
String s3 = foo(() -> switch (i) {default -> bar();});
}
}