MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-27 10:03:11 +07:00
Code Issues Packages Projects Releases Wiki Activity

FIR checker: skip error named reference if receiver is unresolved

Browse Source 
Currently, FIR reports errors caused by previous resolution failure. For
example with unresolved `a` and `b` in code `a.b`, both `a` and `b` are
highlighted. FE1.0 only highlights `a` since it's the root cause. This
change applies this heuristics when reporting FirDiagnostics.

Original commit: fb14b0382428d0482b11b95e32606903293a128b

GitOrigin-RevId: 20ba20c1b51cdb1e991d592112cf72e0ccff8118
This commit is contained in:
Tianyu Geng
2022-01-22 10:53:22 +00:00
committed by intellij-monorepo-bot
parent ff1b014cba
commit f1c2bdbe8c
5 changed files with 26 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
plugins/kotlin/idea/tests/testData/checker/LocalObjects.fir.kt
+21
View File
@@ -0,0 +1,21 @@
object A {
val x : Int = 0
}
open class Foo {
fun foo() : Int = 1
}
fun test() {
A.x
val b = object : Foo() {
}
b.foo()
<error descr="[LOCAL_OBJECT_NOT_ALLOWED] Named object 'B' is a singleton and cannot be local. Try to use anonymous object instead">object B</error> {
fun foo() {}
}
B.foo()
}
val bb = <error descr="[UNRESOLVED_REFERENCE] Unresolved reference: B">B</error>.foo()
plugins/kotlin/idea/tests/testData/checker/LocalObjects.kt
+1 -3
View File
@@ -1,5 +1,3 @@
// FIR_IDENTICAL
// FIR_COMPARISON
object A {
val x : Int = 0
}
@@ -20,4 +18,4 @@
B.foo()
}
val bb = <error descr="[UNRESOLVED_REFERENCE] Unresolved reference: B">B</error>.<error descr="[UNRESOLVED_REFERENCE] Unresolved reference: foo">foo</error>()
val bb = <error descr="[UNRESOLVED_REFERENCE] Unresolved reference: B">B</error>.<error descr="[DEBUG] Reference is not resolved to anything, but is not marked unresolved">foo</error>()
plugins/kotlin/idea/tests/testData/checker/NestedObjects.fir.kt
+1 -1
View File
@@ -25,4 +25,4 @@ package nestedObjects
val b = B
val c = A.B
val d = A.B.A
val e = B.<error descr="[UNRESOLVED_REFERENCE] Unresolved reference: A">A</error>.<error descr="[UNRESOLVED_REFERENCE] Unresolved reference: B">B</error>
val e = B.<error descr="[UNRESOLVED_REFERENCE] Unresolved reference: A">A</error>.B
plugins/kotlin/idea/tests/testData/checker/Unresolved.fir.kt
+2 -2
View File
@@ -23,11 +23,11 @@ fun testUnresolved() {
else -> <error descr="[UNRESOLVED_REFERENCE] Unresolved reference: a">a</error>
}
<error descr="[UNRESOLVED_REFERENCE] Unresolved reference: hasNext"><error descr="[UNRESOLVED_REFERENCE] Unresolved reference: iterator"><error descr="[UNRESOLVED_REFERENCE] Unresolved reference: next">for (j in <error descr="[UNRESOLVED_REFERENCE] Unresolved reference: collection">collection</error>) {
<error descr="[UNRESOLVED_REFERENCE] Unresolved reference: hasNext"><error descr="[UNRESOLVED_REFERENCE] Unresolved reference: next">for (j in <error descr="[UNRESOLVED_REFERENCE] Unresolved reference: collection">collection</error>) {
var i: Int = j
i += 1
foo1(j)
}</error></error></error>
}</error></error>
}
fun foo1(i: Int) {}
plugins/kotlin/idea/tests/testData/checker/infos/SmartCasts.fir.kt
+1 -1
View File
@@ -103,7 +103,7 @@ fun f13(a : A?) {
}
else {
a?.foo()
<error descr="[UNRESOLVED_REFERENCE] Unresolved reference: c">c</error>.<error descr="[UNRESOLVED_REFERENCE] Unresolved reference: bar">bar</error>()
<error descr="[UNRESOLVED_REFERENCE] Unresolved reference: c">c</error>.bar()
}
a?.foo()