unnecessarily qualified statically imported elements: do not ignore chained calls (IDEA-124806)

plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/style/UnnecessarilyQualifiedStaticallyImportedElementInspection.java

@@ -94,7 +94,7 @@ public class UnnecessarilyQualifiedStaticallyImportedElementInspection extends B
       if (!(qualifier instanceof PsiJavaCodeReferenceElement)) {
         return;
       }
-      if (PsiTreeUtil.getParentOfType(reference, PsiReferenceExpression.class, PsiImportStatementBase.class) != null) {
+      if (PsiTreeUtil.getParentOfType(reference, PsiImportStatementBase.class) != null) {
         return;
       }
       if (UnnecessarilyQualifiedStaticUsageInspection.isGenericReference(reference, (PsiJavaCodeReferenceElement)qualifier)) return;

plugins/InspectionGadgets/test/com/siyeh/igtest/style/unnecessarily_qualified_statically_imported_element/chainedMethodCall/expected.xml

@@ -0,0 +1,8 @@
+<problems>
+  <problem>
+    <file>Test.java</file>
+    <line>7</line>
+    <problem_class severity="WARNING" attribute_key="NOT_USED_ELEMENT_ATTRIBUTES">Unnecessarily qualified statically imported element</problem_class>
+    <description>Statically imported element 'foo' is unnecessarily qualified with &lt;code&gt;A&lt;/code&gt; #loc</description>
+  </problem>
+</problems>

plugins/InspectionGadgets/test/com/siyeh/igtest/style/unnecessarily_qualified_statically_imported_element/chainedMethodCall/src/Test.java

@@ -0,0 +1,13 @@
+package p;
+
+import static p.A.foo;
+
+class StaticImport {
+  void example() {
+    A.foo().toString();
+  }
+}
+
+class A {
+  static Object foo() {return null;}
+}

plugins/InspectionGadgets/testsrc/com/siyeh/ig/style/UnnecessarilyQualifiedStaticallyImportedElementInspectionTest.java

@@ -21,7 +21,7 @@ public class UnnecessarilyQualifiedStaticallyImportedElementInspectionTest
   extends IGInspectionTestCase {
 
   public void test() throws Exception {
-    doTest("com/siyeh/igtest/style/unnecessarily_qualified_statically_imported_element",
+    doTest("com/siyeh/igtest/style/unnecessarily_qualified_statically_imported_element/simple",
            new UnnecessarilyQualifiedStaticallyImportedElementInspection());
   }
 
@@ -33,6 +33,10 @@ public class UnnecessarilyQualifiedStaticallyImportedElementInspectionTest
     doTest(getTestName(true));
   }
 
+  public void testChainedMethodCall() throws Exception {
+    doTest(getTestName(true));
+  }
+
   private void doTest(String testName) throws Exception {
     doTest("com/siyeh/igtest/style/unnecessarily_qualified_statically_imported_element/" + testName,
            new UnnecessarilyQualifiedStaticallyImportedElementInspection());