MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2025-12-14 09:12:22 +07:00
Code Issues Packages Projects Releases Wiki Activity

[starter] Remove CompareSettings since we don't use comparision in tests and instead rely on IJ Perf notifications

Browse Source 
GitOrigin-RevId: 5fcde909293efc6f460c8f982ffc04589aa02504
This commit is contained in:
Maxim.Kolmakov
2024-06-26 16:09:15 +02:00
committed by intellij-monorepo-bot
parent fe4b70eaa0
commit f017280b92
2 changed files with 9 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
tools/intellij.tools.ide.metrics.collector/src/com/intellij/tools/ide/metrics/collector/analysis/CompareSetting.kt
View File

@@ -1,12 +0,0 @@
package com.intellij.tools.ide.metrics.collector.analysis
data class CompareSetting(
val compareWithPrevResults: Boolean = false,
val table: String = "",
val notifierHook: ((Conclusion) -> Unit) = { }
) {
companion object {
val notComparing = CompareSetting(false)
val withComparing = CompareSetting(true)
}
}

20
tools/intellij.tools.ide.metrics.collector/src/com/intellij/tools/ide/metrics/collector/metrics/PerformanceMetrics.kt
View File

@@ -1,7 +1,6 @@
package com.intellij.tools.ide.metrics.collector.metrics
import com.intellij.openapi.util.BuildNumber
import com.intellij.tools.ide.metrics.collector.analysis.CompareSetting
import com.intellij.tools.ide.metrics.collector.publishing.ApplicationMetricDto
import java.time.OffsetDateTime
@@ -29,23 +28,22 @@ data class PerformanceMetrics(
}
data class Metric private constructor(@JvmField val id: MetricId,
@JvmField val value: Long,
@JvmField val compareSetting: CompareSetting = CompareSetting.notComparing) {
@JvmField val value: Long) {
companion object {
/**
* Creates instance of the Counter metric type.
* @see com.intellij.tools.ide.metrics.collector.metrics.PerformanceMetrics.MetricId.Counter
*/
fun newCounter(name: String, value: Long, compareSetting: CompareSetting = CompareSetting.notComparing): Metric {
return Metric(id = MetricId.Counter(name), value = value, compareSetting)
fun newCounter(name: String, value: Long): Metric {
return Metric(id = MetricId.Counter(name), value = value)
}
/**
* Creates instance of the Duration metric type.
* @see com.intellij.tools.ide.metrics.collector.metrics.PerformanceMetrics.MetricId.Duration
*/
fun newDuration(name: String, durationMillis: Long, compareSetting: CompareSetting = CompareSetting.notComparing): Metric {
return Metric(id = MetricId.Duration(name), value = durationMillis, compareSetting)
fun newDuration(name: String, durationMillis: Long): Metric {
return Metric(id = MetricId.Duration(name), value = durationMillis)
}
}
}
@@ -54,14 +52,14 @@ data class PerformanceMetrics(
/**
* Shortcut for [com.intellij.tools.ide.metrics.collector.metrics.PerformanceMetrics.MetricId.Counter]
*/
fun newCounter(name: String, value: Long, compareSetting: CompareSetting = CompareSetting.notComparing): Metric =
Metric.newCounter(name, value, compareSetting)
fun newCounter(name: String, value: Long): Metric =
Metric.newCounter(name, value)
/**
* Shortcut for [com.intellij.tools.ide.metrics.collector.metrics.PerformanceMetrics.MetricId.Duration]
*/
fun newDuration(name: String, durationMillis: Long, compareSetting: CompareSetting = CompareSetting.notComparing): Metric =
Metric.newDuration(name, durationMillis, compareSetting)
fun newDuration(name: String, durationMillis: Long): Metric =
Metric.newDuration(name, durationMillis)
}
}