MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-04-20 13:31:28 +07:00
Code Issues Packages Projects Releases Wiki Activity

SimplifyBooleanExpressionAction: do not warn on x = (true)

Browse Source
This commit is contained in:
Tagir Valeev
2018-07-04 17:51:32 +07:00
parent 10d50eb603
commit ee8d7915e8
2 changed files with 10 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
java/java-impl/src/com/intellij/codeInsight/intention/impl/SimplifyBooleanExpressionAction.java
View File

@@ -60,7 +60,9 @@ public class SimplifyBooleanExpressionAction implements IntentionAction{
if (element == null) return null;
PsiExpression expression = PsiTreeUtil.getParentOfType(element, PsiExpression.class);
PsiElement parent = expression;
while (parent instanceof PsiExpression && (PsiType.BOOLEAN.equals(((PsiExpression)parent).getType()) || parent instanceof PsiConditionalExpression)) {
while (parent instanceof PsiExpression &&
!(parent instanceof PsiAssignmentExpression) &&
(PsiType.BOOLEAN.equals(((PsiExpression)parent).getType()) || parent instanceof PsiConditionalExpression)) {
expression = (PsiExpression)parent;
parent = parent.getParent();
}

7
java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/simplifyBooleanExpression/beforeAssignmentParens.java Normal file
View File

@@ -0,0 +1,7 @@
// "Simplify boolean expression" "false"
class X {
void f() {
boolean x;
x = (<caret>false); // Another action "Remove redundant parentheses" is ok here
}
}