MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-18 09:34:34 +07:00
Code Issues Packages Projects Releases Wiki Activity

ControlFlowAnalyzer#acceptBinaryRightOperand: properly convert type for comparison

Browse Source 
Fixes IDEA-200364 Checking equality between int and double confuses "Constant condition and exception" inspection
This commit is contained in:
Tagir Valeev
2018-10-12 10:12:22 +07:00
parent 898f9e2c9d
commit ed64e02bee
2 changed files with 9 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
java/java-analysis-impl/src/com/intellij/codeInspection/dataFlow/ControlFlowAnalyzer.java
+1 -1
View File
@@ -1423,7 +1423,7 @@ public class ControlFlowAnalyzer extends JavaElementVisitor {
TypeConversionUtil.isNumericType(lType) &&
TypeConversionUtil.isNumericType(rType);
PsiType castType = comparingPrimitiveNumeric ? TypeConversionUtil.isFloatOrDoubleType(lType) ? PsiType.DOUBLE : PsiType.LONG : type;
PsiType castType = comparingPrimitiveNumeric ? TypeConversionUtil.unboxAndBalanceTypes(lType, rType) : type;
if (!comparingRef) {
generateBoxingUnboxingInstructionFor(lExpr,castType);
java/java-tests/testData/inspection/dataFlow/fixture/WideningToDouble.java
+8
View File
@@ -5,4 +5,12 @@ class WideningToDouble {
boolean trueValue = <warning descr="Condition 'x == y' is always 'true'">x == y</warning>; // ASSIGNMENT
System.out.println(trueValue); // prints "true"
}
void test() {
int y = 2;
if (<warning descr="Condition 'y == 2.1' is always 'false'">y == 2.1</warning>) {
System.out.println("true");
} else
System.out.println("false");
}
}