MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-18 09:34:34 +07:00
Code Issues Packages Projects Releases Wiki Activity

unchecked warning: don't warn for raw substitutor if parameter type mentions method's type parameter

Browse Source 
GitOrigin-RevId: 8f0b56e55747ff36fffc6d60ae06bb4aea9fcd96
This commit is contained in:
Anna Kozlova
2019-05-29 21:13:43 +03:00
committed by intellij-monorepo-bot
parent 6a68c1583a
commit ebf02771d4
3 changed files with 16 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
java/java-impl/src/com/intellij/codeInspection/uncheckedWarnings/UncheckedWarningLocalInspection.java
+4 -3
View File
@@ -28,9 +28,8 @@ import org.jetbrains.annotations.Nullable;
import javax.swing.*;
import java.awt.*;
import java.util.ArrayList;
import java.util.Collections;
import java.util.List;
import java.util.*;
import java.util.function.Supplier;
public class UncheckedWarningLocalInspection extends AbstractBaseJavaLocalInspectionTool {
@@ -524,7 +523,9 @@ public class UncheckedWarningLocalInspection extends AbstractBaseJavaLocalInspec
final PsiParameter[] parameters = method.getParameterList().getParameters();
for (final PsiParameter parameter : parameters) {
final PsiType parameterType = parameter.getType();
if (PsiTypesUtil.mentionsTypeParametersOrUnboundedWildcard(parameterType, substitutor.getSubstitutionMap().keySet(), true)) {
Set<PsiTypeParameter> typeParameters = new HashSet<>(substitutor.getSubstitutionMap().keySet());
Arrays.stream(method.getTypeParameters()).forEach(typeParameters::remove);
if (PsiTypesUtil.mentionsTypeParametersOrUnboundedWildcard(parameterType, typeParameters, true)) {
final PsiElementFactory elementFactory = JavaPsiFacade.getElementFactory(method.getProject());
PsiType type = elementFactory.createType(method.getContainingClass(), substitutor);
return JavaErrorMessages.message("generics.unchecked.call.to.member.of.raw.type",
java/java-tests/testData/codeInsight/daemonCodeAnalyzer/advHighlighting7/NoUncheckedWarningOnRawSubstitutor.java
+11
View File
@@ -0,0 +1,11 @@
interface Predicate<<warning descr="Type parameter 'T' is never used">T</warning>> {}
class Foo {
static <C extends I> void process(Predicate<C> <warning descr="Parameter 'predicate' is never used">predicate</warning>, C <warning descr="Parameter 'context' is never used">context</warning>) {}
}
interface I {}
class Bar implements I {
Predicate p;
{
Foo.process(p, new Bar());
}
}
java/java-tests/testSrc/com/intellij/java/codeInsight/daemon/LightAdvHighlightingJdk7Test.java
+1 -1
View File
@@ -169,7 +169,7 @@ public class LightAdvHighlightingJdk7Test extends LightDaemonAnalyzerTestCase {
public void testIntersectionTypeCast() { doTest(false, false); }
public void testUsedMethodCalledViaReflectionInTheSameFile() { doTest(true, false); }
public void testCatchSubclassOfThrownException() { doTest(true, false); }
public void testNoUncheckedWarningOnRawSubstitutor() { doTest(true, false); }
public void testArrayInitializerTypeCheckVariableType() { doTest(false, false);}
public void testJavaUtilCollections_NoVerify() {