MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-01-08 15:09:39 +07:00
Code Issues Packages Projects Releases Wiki Activity

field can be local: restrict check for only super/this call (IDEA-152331)

Browse Source
This commit is contained in:
Anna Kozlova
2016-02-29 19:57:33 +01:00
parent 0e606219ba
commit eb9b80c2d5
3 changed files with 30 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
java/java-analysis-impl/src/com/intellij/codeInspection/varScopeCanBeNarrowed/FieldCanBeLocalInspectionBase.java
View File

@@ -117,7 +117,7 @@ public class FieldCanBeLocalInspectionBase extends BaseJavaBatchLocalInspectionT
}
private static void removeFieldsReferencedFromInitializers(final PsiClass aClass, final Set<PsiField> candidates) {
aClass.accept(new JavaRecursiveElementWalkingVisitor() {
aClass.accept(new JavaRecursiveElementVisitor() {
@Override
public void visitMethod(PsiMethod method) {
if (method.isConstructor()) {

14
java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/convert2Local/afterSetterAfterSuperConstructorCall.java Normal file
View File

@@ -0,0 +1,14 @@
// "Convert to local" "true"
import javax.swing.*;
class FieldCanBeLocalTest extends JPanel {
public FieldCanBeLocalTest() {
super();
String name = "MyName";
setName(name);
}
public static void main(String[] args) {}
}

15
java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/convert2Local/beforeSetterAfterSuperConstructorCall.java Normal file
View File

@@ -0,0 +1,15 @@
// "Convert to local" "true"
import javax.swing.*;
class FieldCanBeLocalTest extends JPanel {
private String na<caret>me = "MyName";
public FieldCanBeLocalTest() {
super();
setName(name);
}
public static void main(String[] args) {}
}