MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-27 10:03:11 +07:00
Code Issues Packages Projects Releases Wiki Activity

svn: Refactor "SvnRootsDetector" - remove unnecessary catch

Browse Source
This commit is contained in:
Konstantin Kolosovsky
2018-05-29 21:44:10 +03:00
parent 534714dbb7
commit eb16673113
1 changed files with 9 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files
plugins/svn4idea/src/org/jetbrains/idea/svn/SvnRootsDetector.java
+9 -18
View File
@@ -1,7 +1,6 @@
// Copyright 2000-2017 JetBrains s.r.o. Use of this source code is governed by the Apache 2.0 license that can be found in the LICENSE file.
// Copyright 2000-2018 JetBrains s.r.o. Use of this source code is governed by the Apache 2.0 license that can be found in the LICENSE file.
package org.jetbrains.idea.svn;
import com.intellij.openapi.diagnostic.Logger;
import com.intellij.openapi.util.io.FileUtil;
import com.intellij.openapi.vcs.changes.ChangeListManager;
import com.intellij.openapi.vcs.changes.InvokeAfterUpdateMode;
@@ -28,8 +27,6 @@ import static org.jetbrains.idea.svn.SvnUtil.isAncestor;
*/
public class SvnRootsDetector {
private static final Logger LOG = Logger.getInstance(SvnRootsDetector.class);
@NotNull private final SvnVcs myVcs;
@NotNull private final SvnFileUrlMappingImpl myMapping;
@NotNull private final Result myResult;
@@ -148,22 +145,16 @@ public class SvnRootsDetector {
// TODO: For example they are not set for externals. Probably this logic could be moved to NestedCopiesBuilder instead.
boolean refreshed = false;
// TODO: No checked exceptions are thrown - remove catch/LOG.error/rethrow to fix real cause if any
try {
final File infoFile = virtualToIoFile(info.getFile());
final Status svnStatus = SvnUtil.getStatus(myVcs, infoFile);
final File infoFile = virtualToIoFile(info.getFile());
final Status svnStatus = SvnUtil.getStatus(myVcs, infoFile);
if (svnStatus != null && svnStatus.getURL() != null) {
info.setUrl(svnStatus.getURL());
info.setFormat(myVcs.getWorkingCopyFormat(infoFile, false));
if (svnStatus.getRepositoryRootURL() != null) {
info.setRootURL(svnStatus.getRepositoryRootURL());
}
refreshed = true;
if (svnStatus != null && svnStatus.getURL() != null) {
info.setUrl(svnStatus.getURL());
info.setFormat(myVcs.getWorkingCopyFormat(infoFile, false));
if (svnStatus.getRepositoryRootURL() != null) {
info.setRootURL(svnStatus.getRepositoryRootURL());
}
}
catch (Exception e) {
LOG.info(e);
refreshed = true;
}
return refreshed;