MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-18 09:34:34 +07:00
Code Issues Packages Projects Releases Wiki Activity

ChangeUIDAction: fix review issues: IDEA-CR-32493

Browse Source
This commit is contained in:
Roman.Ivanov
2018-05-22 17:14:46 +07:00
parent 82e0cd840f
commit ea2ac73af8
5 changed files with 7 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
java/java-impl/src/com/intellij/codeInsight/intention/impl/ChangeUIDAction.java
+3 -2
View File
@@ -15,6 +15,7 @@ import com.siyeh.ig.psiutils.CommentTracker;
import org.jetbrains.annotations.Nls;
import org.jetbrains.annotations.NotNull;
import java.security.SecureRandom;
import java.util.Random;
@@ -37,11 +38,11 @@ public class ChangeUIDAction extends PsiElementBaseIntentionAction {
PsiField field = PsiTreeUtil.getParentOfType(element, PsiField.class);
if (field == null) return;
PsiExpression initializer = field.getInitializer();
if (initializer == null) return;
PsiElementFactory factory = JavaPsiFacade.getElementFactory(project);
Application application = ApplicationManager.getApplication();
Random random = application.isUnitTestMode() ? new Random(42) : new Random();
Random random = application.isUnitTestMode() ? new Random(42) : new SecureRandom();
PsiExpression newInitializer = factory.createExpressionFromText(Long.toString(random.nextLong()) + "L", null);
if (initializer == null) return;
new CommentTracker().replaceAndRestoreComments(initializer, newInitializer);
}
java/java-impl/src/intentionDescriptions/ChangeUIDAction/description.html
+1 -1
View File
@@ -1,5 +1,5 @@
<html>
<body>
<p>Intention to change serialVersionUID initializer to randomly generated one</p>
<p>Changes the initializer of a serialVersionUID field to a randomly generated one</p>
</body>
</html>
java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/changeUid/afterChange.java
+1 -1
View File
@@ -1,4 +1,4 @@
// "Randomly change serial version UID" "true"
// "Randomly change 'serialVersionUID' initializer" "true"
import java.util.function.BinaryOperator;
import java.util.function.Function;
java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/changeUid/beforeChange.java
+1 -1
View File
@@ -1,4 +1,4 @@
// "Randomly change serial version UID" "true"
// "Randomly change 'serialVersionUID' initializer" "true"
import java.util.function.BinaryOperator;
import java.util.function.Function;
platform/platform-resources-en/src/messages/CodeInsightBundle.properties
+1 -1
View File
@@ -568,4 +568,4 @@ collapse.selection.overlapping.warning.text=Overlapping fold region(s) exist
collapse.selection.overlapping.warning.ok=Remove
collapse.selection.overlapping.warning.cancel=Cancel
change.uid.action.name=Randomly change serial version UID
change.uid.action.name=Randomly change 'serialVersionUID' initializer