[java-dfa] Remove equivalences when flushing qualified methods

Fixes IDEA-292808 False positive for "Constant conditions and exceptions": always false IF condition in inner class with use of public method

GitOrigin-RevId: b8235e443ecdb9c4a37b4c16b8814e48b607a2d3

java/java-tests/testData/inspection/dataFlow/fixture/ChangeFieldUsedInPureMethod.java

@@ -0,0 +1,24 @@
+// IDEA-292808
+class Test {
+  private class Inner {
+    private boolean firstCheckOk;
+    private boolean secondCheckOk;
+    public void firstCheck(boolean ok) {
+      boolean oldOk = isOk();
+      this.firstCheckOk = ok;
+      boolean newOk = isOk();
+      if (oldOk != newOk)
+        System.out.println(newOk);
+    }
+    public void secondCheck(boolean ok) {
+      boolean oldOk = isOk();
+      this.secondCheckOk = ok;
+      boolean newOk = isOk();
+      if (oldOk != newOk)
+        System.out.println(newOk);
+    }
+    public boolean isOk() {
+      return firstCheckOk || secondCheckOk;
+    }
+  }
+}

java/java-tests/testSrc/com/intellij/java/codeInspection/DataFlowInspectionTest.java

@@ -719,4 +719,5 @@ public class DataFlowInspectionTest extends DataFlowInspectionTestCase {
   public void testBoxingInConstructorArguments() { doTest(); }
   public void testBoxingInArrayDeclaration() { doTest(); }
   public void testNestedVersusSuper() { doTest(); }
+  public void testChangeFieldUsedInPureMethod() { doTest(); }
 }

platform/analysis-impl/src/com/intellij/codeInspection/dataFlow/memory/DfaMemoryStateImpl.java

@@ -1381,8 +1381,8 @@ public class DfaMemoryStateImpl implements DfaMemoryState {
   private void flushQualifiedMethods(@NotNull DfaVariableValue variable) {
     if (variable.isFlushableByCalls()) {
       // Flush method results on field write
-      List<DfaVariableValue> toFlush =
-        ContainerUtil.filter(myVariableTypes.keySet(), DfaVariableValue::containsCalls);
+      List<DfaVariableValue> toFlush = StreamEx.of(myEqClasses).flatMap(cls -> cls == null ? null : StreamEx.of(cls.iterator()))
+        .append(myVariableTypes.keySet()).filter(DfaVariableValue::containsCalls).toList();
       toFlush.forEach(val -> doFlush(val, true));
     }
   }