MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-01-08 15:09:39 +07:00
Code Issues Packages Projects Releases Wiki Activity

spellchecker: skip checking for string literals marked with NonNls (IDEA-50373), add early created tests with vararg spellcheking

Browse Source
This commit is contained in:
Ekaterina Shliakhovetskaja
2010-11-12 16:44:08 +03:00
parent 7fef1fd3b4
commit e7afc83852
3 changed files with 32 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
plugins/java-i18n/src/com/intellij/spellchecker/LiteralExpressionTokenizer.java
View File

@@ -15,13 +15,18 @@
*/
package com.intellij.spellchecker;
import com.intellij.codeInsight.AnnotationUtil;
import com.intellij.psi.PsiLiteralExpression;
import com.intellij.psi.PsiModifierListOwner;
import com.intellij.psi.util.PsiTreeUtil;
import com.intellij.spellchecker.inspections.SplitterFactory;
import com.intellij.spellchecker.tokenizer.Token;
import com.intellij.spellchecker.tokenizer.Tokenizer;
import org.jetbrains.annotations.NotNull;
import org.jetbrains.annotations.Nullable;
import java.util.Collections;
/**
* Created by IntelliJ IDEA.
*
@@ -32,6 +37,11 @@ public class LiteralExpressionTokenizer extends Tokenizer<PsiLiteralExpression>
@Override
@Nullable
public Token[] tokenize(@NotNull PsiLiteralExpression element) {
return new Token[]{new Token<PsiLiteralExpression>(element, SplitterFactory.getInstance().getStringLiteralSplitter())};
final PsiModifierListOwner listOwner = PsiTreeUtil.getParentOfType(element, PsiModifierListOwner.class);
boolean isNls = false;
if (listOwner != null) {
isNls = AnnotationUtil.isAnnotated(listOwner, Collections.singleton(AnnotationUtil.NON_NLS));
}
return !isNls ? new Token[]{new Token<PsiLiteralExpression>(element, SplitterFactory.getInstance().getStringLiteralSplitter())} : null;
}
}

15
plugins/spellchecker/testData/inspection/java/VarArgTest.java Normal file
View File

@@ -0,0 +1,15 @@
public class VarArgTest {
public void a(Test first, Test... rest){
}
public void b(<TYPO descr="Typo: In word 'Testt'">Testt</TYPO> first, <TYPO descr="Typo: In word 'Testt'">Testt</TYPO>... rest){
}
public class Test {
}
public class <TYPO descr="Typo: In word 'Testt'">Testt</TYPO> {
}
}

6
plugins/spellchecker/testSrc/com/intellij/spellchecker/inspection/JavaSpellcheckingTest.java
View File

@@ -36,4 +36,10 @@ public class JavaSpellcheckingTest extends SpellcheckerInspectionTestCase {
public void testTypoInJava() throws Throwable {
doTest("GenericTestt.java", SpellCheckerInspectionToolProvider.getInspectionTools());
}
public void testVarArg() throws Throwable {
doTest("VarArgTest.java", SpellCheckerInspectionToolProvider.getInspectionTools());
}
}