coverage: cleanup

This commit is contained in:
Roman Chernyatchik
2011-10-11 19:30:30 +04:00
parent 22c5f8c195
commit e75ca73c22
2 changed files with 9 additions and 23 deletions
@@ -16,9 +16,10 @@
package com.intellij.execution.configuration;
import com.intellij.execution.Location;
import com.intellij.execution.configurations.*;
import com.intellij.execution.configurations.GeneralCommandLine;
import com.intellij.execution.configurations.RunConfigurationBase;
import com.intellij.execution.configurations.RunnerSettings;
import com.intellij.execution.process.ProcessHandler;
import com.intellij.execution.runners.ProgramRunner;
import com.intellij.openapi.options.SettingsEditor;
import com.intellij.openapi.util.InvalidDataException;
import com.intellij.openapi.util.WriteExternalException;
@@ -77,16 +78,6 @@ public abstract class RunConfigurationExtensionBase<T extends RunConfigurationBa
protected abstract void validateConfiguration(@NotNull final T configuration,
final boolean isExecution) throws Exception;
/**
* validate runner settings
*/
protected void checkRunnerSettings(@NotNull T configuration,
@NotNull final ProgramRunner runner,
@Nullable final RunnerSettings runnerSettings,
@Nullable final ConfigurationPerRunnerSettings configurationPerRunnerSettings)
throws RuntimeConfigurationException {
}
/**
* Setup extension settings for created run configuration
*
@@ -2,12 +2,10 @@ package com.intellij.execution.configuration;
import com.google.common.collect.Maps;
import com.intellij.execution.Location;
import com.intellij.execution.configurations.ConfigurationPerRunnerSettings;
import com.intellij.execution.configurations.GeneralCommandLine;
import com.intellij.execution.configurations.RunConfigurationBase;
import com.intellij.execution.configurations.RunnerSettings;
import com.intellij.execution.process.ProcessHandler;
import com.intellij.execution.runners.ProgramRunner;
import com.intellij.openapi.extensions.ExtensionPointName;
import com.intellij.openapi.extensions.Extensions;
import com.intellij.openapi.options.SettingsEditor;
@@ -19,7 +17,10 @@ import org.jdom.Element;
import org.jetbrains.annotations.NotNull;
import org.jetbrains.annotations.Nullable;
import java.util.*;
import java.util.ArrayList;
import java.util.List;
import java.util.Map;
import java.util.TreeMap;
/**
* @author traff
@@ -117,13 +118,6 @@ public class RunConfigurationExtensionsManager<U extends RunConfigurationBase, T
}
}
public void checkRunnerSettings(@NotNull final U configuration, ProgramRunner runner, RunnerSettings runnerSettings, ConfigurationPerRunnerSettings configPerRunnerSettings) throws Exception {
// only for enabled extensions
for (T extension : getEnabledExtensions(configuration, null)) {
extension.checkRunnerSettings(configuration, runner, runnerSettings, configPerRunnerSettings);
}
}
public void extendCreatedConfiguration(@NotNull final U configuration,
@NotNull final Location location) {
for (T extension : getApplicableExtensions(configuration)) {
@@ -138,7 +132,8 @@ public class RunConfigurationExtensionsManager<U extends RunConfigurationBase, T
}
public void patchCommandLine(@NotNull final U configuration,
final RunnerSettings runnerSettings, @NotNull final GeneralCommandLine cmdLine,
final RunnerSettings runnerSettings,
@NotNull final GeneralCommandLine cmdLine,
@NotNull final AbstractRunConfiguration.RunnerType type) {
// only for enabled extensions
for (T extension : getEnabledExtensions(configuration, runnerSettings)) {