[java-refactoring] Introduce variable: do not try to add cast if the type is non-variable type

Found by property testing
Fixes EA-248598 - [ExtractVar] AE: JavaParserUtil.parseFragment

GitOrigin-RevId: 91d32dd33ef6c75ed750419b06654acffba6d684

java/java-impl/src/com/intellij/refactoring/introduceVariable/JavaVariableInplaceIntroducer.java

@@ -23,8 +23,6 @@ import com.intellij.openapi.actionSystem.Shortcut;
 import com.intellij.openapi.application.ApplicationManager;
 import com.intellij.openapi.command.CommandProcessor;
 import com.intellij.openapi.command.WriteCommandAction;
-import com.intellij.openapi.diagnostic.Attachment;
-import com.intellij.openapi.diagnostic.RuntimeExceptionWithAttachments;
 import com.intellij.openapi.editor.Document;
 import com.intellij.openapi.editor.Editor;
 import com.intellij.openapi.editor.RangeMarker;
@@ -370,13 +368,8 @@ public class JavaVariableInplaceIntroducer extends AbstractJavaInplaceIntroducer
             final PsiExpression initializer = psiVariable.getInitializer();
             LOG.assertTrue(initializer != null);
             final PsiType type = initializer.getType();
-            if (((PsiReferenceExpression)parent).resolve() == null && type != null && !type.equals(psiVariable.getType())) {
-              if (LambdaUtil.notInferredType(type)) {
-                throw new RuntimeExceptionWithAttachments(
-                  "Unexpected initializer type: " + type,
-                  new Attachment("variable.txt", psiVariable.getText()), new Attachment("reference.txt", parent.getText()),
-                  new Attachment("file.txt", file.getText()));
-              }
+            if (((PsiReferenceExpression)parent).resolve() == null && type != null && !type.equals(psiVariable.getType()) &&
+                !LambdaUtil.notInferredType(type) && !PsiType.NULL.equals(type)) {
               final PsiElementFactory elementFactory = JavaPsiFacade.getElementFactory(project);
               final PsiExpression castedExpr =
                 elementFactory.createExpressionFromText("((" + type.getCanonicalText() + ")" + referenceExpression.getText() + ")", parent);

java/java-tests/testData/refactoring/inplaceIntroduceVariable/lambdaParameterAddCast.java

@@ -0,0 +1,10 @@
+public class lambdaParameterAddCast {
+  void consume(String str) {}
+
+  void test() {
+    Object r = foo -> {
+      consume(<caret>foo);
+      System.out.println(foo.blahblah());
+    };
+  }
+}

java/java-tests/testData/refactoring/inplaceIntroduceVariable/lambdaParameterAddCast_after.java

@@ -0,0 +1,11 @@
+public class lambdaParameterAddCast {
+  void consume(String str) {}
+
+  void test() {
+    Object r = foo -> {
+        String foo1 = (String) foo;
+        consume(foo1);
+      System.out.println(foo1.blahblah());
+    };
+  }
+}

java/java-tests/testData/refactoring/inplaceIntroduceVariable/nullTypeAddCast.java

@@ -0,0 +1,17 @@
+public class NullTypeAddCast {
+  static class MyMegaClass {
+    int myMegaMethod() {
+      return 0;
+    }
+  }
+
+  interface MyInterface {}
+
+  void consume(MyInterface intf) {}
+
+  void test() {
+    var x = foo;
+    consume(x);
+    System.out.println(<selection>x</selection>.myMegaMethod());
+  }
+}

java/java-tests/testData/refactoring/inplaceIntroduceVariable/nullTypeAddCast_after.java

@@ -0,0 +1,18 @@
+public class NullTypeAddCast {
+  static class MyMegaClass {
+    int myMegaMethod() {
+      return 0;
+    }
+  }
+
+  interface MyInterface {}
+
+  void consume(MyInterface intf) {}
+
+  void test() {
+    var x = foo;
+      Object x1 = x;
+      consume(x1);
+    System.out.println(x1.myMegaMethod());
+  }
+}

java/java-tests/testSrc/com/intellij/java/refactoring/InplaceIntroduceVariableTest.java

@@ -212,6 +212,14 @@ public class InplaceIntroduceVariableTest extends AbstractJavaInplaceIntroduceTe
     doTest(null);
   }
 
+  public void testNullTypeAddCast() {
+    doTestReplaceChoice("Replace all 0 occurrences");
+  }
+
+  public void testLambdaParameterAddCast() {
+    doTestReplaceChoice("Replace all 0 occurrences");
+  }
+
   private void doTestStopEditing(Consumer<? super AbstractInplaceIntroducer> pass) {
     String name = getTestName(true);
     configureByFile(getBasePath() + name + getExtension());