MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-27 10:03:11 +07:00
Code Issues Packages Projects Releases Wiki Activity

assert that document saving and commit happen with write actions allowed

Browse Source
This commit is contained in:
peter
2016-04-11 10:31:30 +02:00
parent c58e19e949
commit e51f4336b8
2 changed files with 21 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
platform/core-impl/src/com/intellij/psi/impl/PsiDocumentManagerBase.java
+10
View File
@@ -214,6 +214,11 @@ public abstract class PsiDocumentManagerBase extends PsiDocumentManager implemen
@Override
public void commitAllDocuments() {
ApplicationManager.getApplication().assertIsDispatchThread();
if (!((TransactionGuardImpl)TransactionGuard.getInstance()).isWriteActionAllowed()) {
// please assign exceptions here to Peter
LOG.error("Write access is not allowed in this context, see TransactionGuard documentation for details");
}
if (myUncommittedDocuments.isEmpty()) return;
final Document[] documents = getUncommittedDocuments();
@@ -286,6 +291,11 @@ public abstract class PsiDocumentManagerBase extends PsiDocumentManager implemen
@Override
public void commitDocument(@NotNull final Document doc) {
if (!((TransactionGuardImpl)TransactionGuard.getInstance()).isWriteActionAllowed()) {
// please assign exceptions here to Peter
LOG.error("Write access is not allowed in this context, see TransactionGuard documentation for details");
}
final Document document = doc instanceof DocumentWindow ? ((DocumentWindow)doc).getDelegate() : doc;
if (!isCommitted(document)) {
doCommit(document);
platform/platform-impl/src/com/intellij/openapi/fileEditor/impl/FileDocumentManagerImpl.java
+11
View File
@@ -28,6 +28,8 @@ import com.intellij.diff.util.DiffUserDataKeys;
import com.intellij.openapi.Disposable;
import com.intellij.openapi.application.AccessToken;
import com.intellij.openapi.application.ApplicationManager;
import com.intellij.openapi.application.TransactionGuard;
import com.intellij.openapi.application.TransactionGuardImpl;
import com.intellij.openapi.command.CommandProcessor;
import com.intellij.openapi.command.UndoConfirmationPolicy;
import com.intellij.openapi.diagnostic.Logger;
@@ -298,6 +300,10 @@ public class FileDocumentManagerImpl extends FileDocumentManager implements Virt
*/
public void saveAllDocuments(boolean isExplicit) {
ApplicationManager.getApplication().assertIsDispatchThread();
if (!((TransactionGuardImpl)TransactionGuard.getInstance()).isWriteActionAllowed()) {
// please assign exceptions here to Peter
LOG.error("Write access is not allowed in this context, see TransactionGuard documentation for details");
}
myMultiCaster.beforeAllDocumentsSaving();
if (myUnsavedDocuments.isEmpty()) return;
@@ -338,6 +344,11 @@ public class FileDocumentManagerImpl extends FileDocumentManager implements Virt
public void saveDocument(@NotNull final Document document, final boolean explicit) {
ApplicationManager.getApplication().assertIsDispatchThread();
if (!((TransactionGuardImpl)TransactionGuard.getInstance()).isWriteActionAllowed()) {
// please assign exceptions here to Peter
LOG.error("Write access is not allowed in this context, see TransactionGuard documentation for details");
}
if (!myUnsavedDocuments.contains(document)) return;
try {