MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-27 10:03:11 +07:00
Code Issues Packages Projects Releases Wiki Activity

IDEA-76930 Fix memory leak: don't create AuthDialog if not going to show it

Browse Source
This commit is contained in:
Kirill Likhodedov
2011-11-14 19:50:59 +03:00
parent 42a2cfa3b8
commit e399d07d07
1 changed files with 17 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files
plugins/git4idea/src/git4idea/jgit/GitHttpCredentialsProvider.java
+17 -10
View File
@@ -91,12 +91,13 @@ public class GitHttpCredentialsProvider extends CredentialsProvider {
password = myPassword;
}
final AuthDialog dialog = new AuthDialog(myProject, "Login required", "Login to " + myRemoteUrl, username, password, false);
boolean rememberPassword = myRememberPassword;
boolean ok;
if (username != null && password != null && !myShowDialog) {
ok = true;
myDialogShown = false;
} else {
final AuthDialog dialog = new AuthDialog(myProject, "Login required", "Login to " + myRemoteUrl, username, password, false);
UIUtil.invokeAndWaitIfNeeded(new Runnable() {
@Override
public void run() {
@@ -105,21 +106,27 @@ public class GitHttpCredentialsProvider extends CredentialsProvider {
});
ok = dialog.isOK();
myDialogShown = true;
if (ok) {
username = dialog.getUsername();
password = dialog.getPassword();
rememberPassword = dialog.isRememberPassword();
}
}
if (!ok) {
myCancelled = true;
myRememberPassword = false; // in case of re-usage of the provider
} else {
if (ok) {
if (userNameItem != null) {
userNameItem.setValue(dialog.getUsername());
userNameItem.setValue(username);
}
if (passwordItem != null) {
passwordItem.setValue(dialog.getPassword().toCharArray());
passwordItem.setValue(password.toCharArray());
}
myRememberPassword = dialog.isRememberPassword();
myPassword = dialog.getPassword();
myUserName = dialog.getUsername();
myRememberPassword = rememberPassword;
myPassword = password;
myUserName = username;
}
else {
myCancelled = true;
myRememberPassword = false; // in case of re-usage of the provider
}
return ok;
}