constructor refs: forbid raw constructor references with explicit new type args

(cherry picked from commit a127d801aa080f2efe3784edd5cca419dccfda2e)

java/java-analysis-impl/src/com/intellij/codeInsight/daemon/impl/analysis/HighlightVisitorImpl.java

@@ -1238,6 +1238,10 @@ public class HighlightVisitorImpl extends JavaElementVisitor implements Highligh
         }
       }
     }
+    
+    if (!myHolder.hasErrorResults()) {
+      myHolder.add(PsiMethodReferenceHighlightingUtil.checkRawConstructorReference(expression));
+    }
 
     if (!myHolder.hasErrorResults()) {
       myHolder.add(HighlightUtil.checkUnhandledExceptions(expression, expression.getTextRange()));

java/java-analysis-impl/src/com/intellij/codeInsight/daemon/impl/analysis/PsiMethodReferenceHighlightingUtil.java

@@ -0,0 +1,39 @@
+/*
+ * Copyright 2000-2013 JetBrains s.r.o.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package com.intellij.codeInsight.daemon.impl.analysis;
+
+import com.intellij.codeInsight.daemon.impl.HighlightInfo;
+import com.intellij.codeInsight.daemon.impl.HighlightInfoType;
+import com.intellij.psi.*;
+
+public class PsiMethodReferenceHighlightingUtil {
+  public static HighlightInfo checkRawConstructorReference(PsiMethodReferenceExpression expression) {
+    if (expression.isConstructor()) {
+      PsiType[] typeParameters = expression.getTypeParameters();
+      if (typeParameters.length > 0) {
+        PsiElement qualifier = expression.getQualifier();
+        if (qualifier instanceof PsiReferenceExpression) {
+          PsiElement resolve = ((PsiReferenceExpression)qualifier).resolve();
+          if (resolve instanceof PsiClass && ((PsiClass)resolve).hasTypeParameters()) {
+            return HighlightInfo.newHighlightInfo(HighlightInfoType.ERROR).range(expression)
+              .descriptionAndTooltip("Raw constructor reference with explicit type parameters for constructor").create();
+          }
+        }
+      }
+    }
+    return null;
+  }
+}

java/java-tests/testData/codeInsight/daemonCodeAnalyzer/lambda/newMethodRef/RawConstructorReferenceWithTypeParams.java

@@ -0,0 +1,13 @@
+class Test {
+    interface I {
+        Object _();
+    }
+    static class Foo<X> {}
+    static class Foo1 {}
+    void testAssign() {
+        I o = <error descr="Raw constructor reference with explicit type parameters for constructor">Foo::<String>new</error>;
+        I o1 = Foo1::<String>new;
+
+    }
+}
+

java/java-tests/testSrc/com/intellij/codeInsight/daemon/lambda/NewMethodRefHighlightingTest.java

@@ -92,6 +92,10 @@ public class NewMethodRefHighlightingTest extends LightDaemonAnalyzerTestCase {
     doTest();
   }
 
+  public void testRawConstructorReferenceWithTypeParams() throws Exception {
+    doTest();
+  }
+
   private void doTest() {
     doTest(false);
   }