MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-27 10:03:11 +07:00
Code Issues Packages Projects Releases Wiki Activity

IJPL-222467 StubBuildCachedValuesManager: do not require nested cached value computing to use StubBuildCachedValuesManager.

Browse Source 
GitOrigin-RevId: 4f881a20b261339b91d3b27246e15137a493a74f
This commit is contained in:
Piotr Tomiak
2025-12-16 18:11:33 +00:00
committed by intellij-monorepo-bot
parent 35f63db64e
commit e245769efe
2 changed files with 31 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
platform/core-api/src/com/intellij/psi/stubs/StubBuildCachedValuesManager.kt
+30 -6
View File
@@ -41,6 +41,7 @@ import java.util.function.Function
object StubBuildCachedValuesManager {
private val myStubBuildId = ThreadLocal<Long?>()
private val myComputingCachedValue = ThreadLocal<Boolean?>()
private val ourStubBuildIdCounter = AtomicLong()
@JvmStatic
@@ -59,6 +60,11 @@ object StubBuildCachedValuesManager {
val isBuildingStubs: Boolean
get() = myStubBuildId.get() != null
@JvmStatic
@get:ApiStatus.Internal
val isComputingCachedValue: Boolean
get() = myComputingCachedValue.get() == true
private val stubBuildId: Long?
get() = myStubBuildId.get()
@@ -74,7 +80,12 @@ object StubBuildCachedValuesManager {
val node = dataHolder.getNode()
var current = node.getUserData(stubBuildingKey)
if (current == null || current.buildId != stubBuildId) {
current = StubBuildCachedValue<T>(stubBuildId, provider.apply(parameter))
myComputingCachedValue.set(true)
current = try {
StubBuildCachedValue<T>(stubBuildId, provider.apply(parameter))
} finally {
myComputingCachedValue.remove()
}
node.putUserData<StubBuildCachedValue<T>>(stubBuildingKey, current)
}
return current.value
@@ -95,7 +106,12 @@ object StubBuildCachedValuesManager {
if (stubBuildId != null) {
var current = node.getUserData(stubBuildingKey)
if (current == null || current.buildId != stubBuildId) {
val value = provider.compute(parameter)
myComputingCachedValue.set(true)
val value = try {
provider.compute(parameter)
} finally {
myComputingCachedValue.remove()
}
current = StubBuildCachedValue(stubBuildId, value.getValue())
node.putUserData(stubBuildingKey, current)
}
@@ -120,8 +136,12 @@ object StubBuildCachedValuesManager {
val node = dataHolder.getNode()
var current = node.getUserData(stubBuildingKey)
if (current == null || current.buildId != stubBuildId) {
val value = provider.compute(parameter)
myComputingCachedValue.set(true)
val value = try {
provider.compute(parameter)
} finally {
myComputingCachedValue.remove()
}
current = StubBuildCachedValue(stubBuildId, value.getValue())
node.putUserData(stubBuildingKey, current)
}
@@ -177,8 +197,12 @@ object StubBuildCachedValuesManager {
val node = dataHolder.getNode()
var current = node.getUserData(stubBuildingKey)
if (current == null || current.buildId != stubBuildId) {
val value = provider.compute()
myComputingCachedValue.set(true)
val value = try {
provider.compute()
} finally {
myComputingCachedValue.remove()
}
current = StubBuildCachedValue(stubBuildId, value?.getValue())
node.putUserData(stubBuildingKey, current)
}
platform/core-api/src/com/intellij/psi/util/CachedValuesManager.java
+1
View File
@@ -77,6 +77,7 @@ public abstract class CachedValuesManager {
P parameter) {
ParameterizedCachedValue<T, P> value;
if (StubBuildCachedValuesManager.isBuildingStubs()
&& !StubBuildCachedValuesManager.isComputingCachedValue()
&& (ApplicationManager.getApplication().isUnitTestMode() || ApplicationManager.getApplication().isInternal())) {
Logger.getInstance(getClass()).error("StubBuildCachedValuesManager should be used during stub building to improve performance");
}