2/2 EmptyRangeInspection: support rangeUntil operator

^KTIJ-22378 Fixed

GitOrigin-RevId: 2d94ee8f6b91e1b32a7cb205ce7e43d0818a6201

plugins/kotlin/idea/src/org/jetbrains/kotlin/idea/inspections/AbstractRangeInspection.kt

@@ -33,15 +33,14 @@ abstract class AbstractRangeInspection : AbstractKotlinInspection() {
         val context = lazy { expression.analyze(BodyResolveMode.PARTIAL) }
         when (expression.getRangeBinaryExpressionType(context) ?: return) {
             RangeKtExpressionType.rangeTo -> visitRangeTo(expression, context.value, holder)
-            RangeKtExpressionType.rangeUntil -> Unit
+            RangeKtExpressionType.until, RangeKtExpressionType.rangeUntil -> visitUntilOrRangeUntil(expression, context.value, holder)
             RangeKtExpressionType.downTo -> visitDownTo(expression, context.value, holder)
-            RangeKtExpressionType.until -> visitUntil(expression, context.value, holder)
         }
     }
 
     abstract fun visitRangeTo(expression: KtExpression, context: BindingContext, holder: ProblemsHolder)
 
-    abstract fun visitUntil(expression: KtExpression, context: BindingContext, holder: ProblemsHolder)
+    abstract fun visitUntilOrRangeUntil(expression: KtExpression, context: BindingContext, holder: ProblemsHolder)
 
     abstract fun visitDownTo(expression: KtExpression, context: BindingContext, holder: ProblemsHolder)
 

plugins/kotlin/idea/src/org/jetbrains/kotlin/idea/inspections/EmptyRangeInspection.kt

@@ -30,7 +30,7 @@ class EmptyRangeInspection : AbstractRangeInspection() {
         }
     }
 
-    override fun visitUntil(expression: KtExpression, context: BindingContext, holder: ProblemsHolder) {
+    override fun visitUntilOrRangeUntil(expression: KtExpression, context: BindingContext, holder: ProblemsHolder) {
         expression.startAndEndValueSignedOrNull(context)?.let { (startValue, endValue) ->
             when {
                 startValue > endValue -> holder.registerProblem(expression, downTo = true)

plugins/kotlin/idea/src/org/jetbrains/kotlin/idea/inspections/ReplaceRangeToWithUntilInspection.kt

@@ -29,7 +29,7 @@ class ReplaceRangeToWithUntilInspection : AbstractRangeInspection() {
         )
     }
 
-    override fun visitUntil(expression: KtExpression, context: BindingContext, holder: ProblemsHolder) {
+    override fun visitUntilOrRangeUntil(expression: KtExpression, context: BindingContext, holder: ProblemsHolder) {
     }
 
     override fun visitDownTo(expression: KtExpression, context: BindingContext, holder: ProblemsHolder) {

plugins/kotlin/idea/tests/test/org/jetbrains/kotlin/idea/inspections/LocalInspectionTestGenerated.java

@@ -4660,6 +4660,16 @@ public abstract class LocalInspectionTestGenerated extends AbstractLocalInspecti
             runTest("testData/inspectionsLocal/emptyRange/downTo2.kt");
         }
 
+        @TestMetadata("rangeUntil.kt")
+        public void testRangeUntil() throws Exception {
+            runTest("testData/inspectionsLocal/emptyRange/rangeUntil.kt");
+        }
+
+        @TestMetadata("rangeUntil2.kt")
+        public void testRangeUntil2() throws Exception {
+            runTest("testData/inspectionsLocal/emptyRange/rangeUntil2.kt");
+        }
+
         @TestMetadata("simple.kt")
         public void testSimple() throws Exception {
             runTest("testData/inspectionsLocal/emptyRange/simple.kt");

plugins/kotlin/idea/tests/testData/inspectionsLocal/emptyRange/rangeUntil.kt

@@ -0,0 +1,5 @@
+// PROBLEM: This range is empty. Did you mean to use 'downTo'?
+// WITH_STDLIB
+fun test() {
+    <caret>0..<-1
+}

plugins/kotlin/idea/tests/testData/inspectionsLocal/emptyRange/rangeUntil.kt.after

@@ -0,0 +1,5 @@
+// PROBLEM: This range is empty. Did you mean to use 'downTo'?
+// WITH_STDLIB
+fun test() {
+    <caret>0 downTo -1
+}

plugins/kotlin/idea/tests/testData/inspectionsLocal/emptyRange/rangeUntil2.kt

@@ -0,0 +1,5 @@
+// PROBLEM: This range is empty. Did you mean to use 'rangeTo'?
+// WITH_STDLIB
+fun test() {
+    <caret>0..<0
+}

plugins/kotlin/idea/tests/testData/inspectionsLocal/emptyRange/rangeUntil2.kt.after

@@ -0,0 +1,5 @@
+// PROBLEM: This range is empty. Did you mean to use 'rangeTo'?
+// WITH_STDLIB
+fun test() {
+    <caret>0..0
+}