MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-27 10:03:11 +07:00
Code Issues Packages Projects Releases Wiki Activity

[vcs-log] remove myDataLoaderQueue that is used only during initialization

Browse Source 
myDataLoaderQueue only used in initialize method to read first block. This means it can be replaced with a single runProcessWithProgressAsynchronously call.
This commit is contained in:
Julia Beliaeva
2017-03-24 15:08:12 +03:00
parent b7ee82ab84
commit e0c38f604c
1 changed files with 4 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files
platform/vcs-log/impl/src/com/intellij/vcs/log/data/VcsLogData.java
+4 -12
View File
@@ -20,10 +20,7 @@ import com.intellij.openapi.Disposable;
import com.intellij.openapi.application.ApplicationManager;
import com.intellij.openapi.components.ServiceManager;
import com.intellij.openapi.diagnostic.Logger;
import com.intellij.openapi.progress.BackgroundTaskQueue;
import com.intellij.openapi.progress.ProcessCanceledException;
import com.intellij.openapi.progress.ProgressIndicator;
import com.intellij.openapi.progress.Task;
import com.intellij.openapi.progress.*;
import com.intellij.openapi.project.Project;
import com.intellij.openapi.util.Disposer;
import com.intellij.openapi.util.registry.Registry;
@@ -58,7 +55,6 @@ public class VcsLogData implements Disposable, VcsLogDataProvider {
@NotNull private final Project myProject;
@NotNull private final Map<VirtualFile, VcsLogProvider> myLogProviders;
@NotNull private final BackgroundTaskQueue myDataLoaderQueue;
@NotNull private final MiniDetailsGetter myMiniDetailsGetter;
@NotNull private final CommitDetailsGetter myDetailsGetter;
@@ -89,7 +85,6 @@ public class VcsLogData implements Disposable, VcsLogDataProvider {
@NotNull FatalErrorHandler fatalErrorsConsumer) {
myProject = project;
myLogProviders = logProviders;
myDataLoaderQueue = new BackgroundTaskQueue(project, "Loading history...");
myUserRegistry = (VcsUserRegistryImpl)ServiceManager.getService(project, VcsUserRegistry.class);
myFatalErrorsConsumer = fatalErrorsConsumer;
@@ -174,9 +169,7 @@ public class VcsLogData implements Disposable, VcsLogDataProvider {
}
public void initialize() {
StopWatch initSw = StopWatch.start("initialize");
myDataLoaderQueue.clear();
StopWatch stopWatch = StopWatch.start("initialize");
Task.Backgroundable backgroundable = new Task.Backgroundable(myProject, "Loading History...", false) {
@Override
public void run(@NotNull ProgressIndicator indicator) {
@@ -185,10 +178,10 @@ public class VcsLogData implements Disposable, VcsLogDataProvider {
readCurrentUser();
DataPack dataPack = myRefresher.readFirstBlock();
fireDataPackChangeEvent(dataPack);
initSw.report();
stopWatch.report();
}
};
myDataLoaderQueue.run(backgroundable, null, myRefresher.getProgress().createProgressIndicator());
ProgressManager.getInstance().runProcessWithProgressAsynchronously(backgroundable, myRefresher.getProgress().createProgressIndicator());
}
private void readCurrentUser() {
@@ -274,7 +267,6 @@ public class VcsLogData implements Disposable, VcsLogDataProvider {
@Override
public void dispose() {
myDataLoaderQueue.clear();
resetState();
}