MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-27 10:03:11 +07:00
Code Issues Packages Projects Releases Wiki Activity

android lint: typography tests

Browse Source
This commit is contained in:
Eugene Kudelevsky
2012-02-06 15:28:00 +04:00
parent a8e0e4513c
commit e051e1bb0c
4 changed files with 12 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
plugins/android/src/org/jetbrains/android/inspections/lint/TypographyQuickFix.java
+8 -1
View File
@@ -2,6 +2,7 @@ package org.jetbrains.android.inspections.lint;
import com.android.tools.lint.checks.TypographyDetector;
import com.android.tools.lint.detector.api.Issue;
import com.intellij.openapi.application.ApplicationManager;
import com.intellij.openapi.editor.Editor;
import com.intellij.psi.PsiElement;
import com.intellij.psi.util.PsiTreeUtil;
@@ -42,7 +43,13 @@ class TypographyQuickFix implements AndroidLintQuickFix {
final StringBuilder builder = new StringBuilder(value);
for (TypographyDetector.ReplaceEdit edit : edits) {
builder.replace(edit.offset, edit.offset + edit.length, edit.replaceWith);
String with = edit.replaceWith;
if (ApplicationManager.getApplication().isUnitTestMode()) {
with = with.replace('\u2013', '~').replace('\u2018', '{').replace('\u2019', '}');
}
builder.replace(edit.offset, edit.offset + edit.length, with);
}
final String newValue = builder.toString();
plugins/android/testData/lint/typographyDashes_after.xml
+1 -1
View File
@@ -1,4 +1,4 @@
<?xml version="1.0" encoding="utf-8"?>
<resources>
<string name="s">10–20</string>
<string name="s">10~20</string>
</resources>
plugins/android/testData/lint/typographyQuotes_after.xml
+1 -1
View File
@@ -1,5 +1,5 @@
<?xml version="1.0" encoding="utf-8"?>
<resources>
<string name="app_name">untitled303</string>
<string name="app_name1">aba ‘aba’</string>
<string name="app_name1">aba {aba}</string>
</resources>
plugins/android/testSrc/org/jetbrains/android/AndroidLintTest.java
+2 -2
View File
@@ -140,7 +140,7 @@ public class AndroidLintTest extends AndroidTestCase {
"/res/layout/layout.xml", "xml");
}
/*public void testTypographyDashes() throws Exception {
public void testTypographyDashes() throws Exception {
doTestWithFix(new AndroidLintInspectionToolProvider.AndroidLintTypographyDashesInspection(),
AndroidBundle.message("android.lint.inspections.replace.with.suggested.characters"),
"/res/values/typography.xml", "xml");
@@ -150,7 +150,7 @@ public class AndroidLintTest extends AndroidTestCase {
doTestWithFix(new AndroidLintInspectionToolProvider.AndroidLintTypographyQuotesInspection(),
AndroidBundle.message("android.lint.inspections.replace.with.suggested.characters"),
"/res/values/typography.xml", "xml");
}*/
}
private void doTestNoFix(@NotNull AndroidLintInspectionBase inspection, @NotNull String copyTo, @NotNull String extension)
throws IOException {