java: properly handle refs to protected inner classes in 'Suspicious package-private access' inspection (IDEA-200047)

plugins/InspectionGadgets/src/com/siyeh/ig/dependency/SuspiciousPackagePrivateAccessInspection.java

@@ -149,10 +149,10 @@ public class SuspiciousPackagePrivateAccessInspection extends AbstractBaseUastLo
       accessObjectType = (PsiClass)element;
     }
 
-    UClass sourceClass = UastUtils.getParentOfType(sourceNode, UClass.class);
+    PsiElement sourcePsi = sourceNode.getSourcePsi();
+    PsiClass sourceClass = PsiTreeUtil.getParentOfType(sourcePsi, PsiClass.class);
     if (sourceClass == null) return false;
-    PsiClass sourceClassJava = sourceClass.getJavaPsi();
-    return JavaResolveUtil.canAccessProtectedMember(member, memberClass, accessObjectType, sourceClassJava, member.hasModifierProperty(PsiModifier.STATIC));
+    return JavaResolveUtil.canAccessProtectedMember(member, memberClass, accessObjectType, sourceClass, member.hasModifierProperty(PsiModifier.STATIC));
   }
 
   private boolean isPackageLocalAccessSuspicious(Module sourceModule, Module targetModule) {

plugins/InspectionGadgets/test/com/siyeh/igtest/dependency/suspicious_package_private_access/dep/xxx/ProtectedMembers.java

@@ -6,4 +6,7 @@ public class ProtectedMembers {
 
   static protected void staticMethod() {
   }
+
+  protected static class StaticInner {
+  }
 }

plugins/InspectionGadgets/test/com/siyeh/igtest/dependency/suspicious_package_private_access/src/AccessingProtectedMembers.java

@@ -18,5 +18,14 @@ class AccessingProtectedMembersFromSubclass extends ProtectedMembers {
     aClass.<warning descr="Method ProtectedMembers.method() is protected and used not through a subclass here, but declared in a different module 'dep'">method</warning>();
     AccessingProtectedMembersFromSubclass myInstance = new AccessingProtectedMembersFromSubclass();
     myInstance.method();
+
+    ProtectedMembers.StaticInner inner1;
+    StaticInner inner2;
+  }
+
+  public static class StaticInnerImpl1 extends ProtectedMembers.StaticInner {
+  }
+
+  public static class StaticInnerImpl2 extends StaticInner {
   }
 }