MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-27 10:03:11 +07:00
Code Issues Packages Projects Releases Wiki Activity

don't keep hard references to PSI in CreatePropertyFix

Browse Source
This commit is contained in:
peter
2012-03-01 16:51:53 +04:00
parent 2694e3365d
commit dd9d0a9216
1 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
plugins/properties/src/com/intellij/lang/properties/references/CreatePropertyFix.java
+5 -4
View File
@@ -29,6 +29,7 @@ import com.intellij.openapi.diagnostic.Logger;
import com.intellij.openapi.editor.Editor;
import com.intellij.openapi.project.Project;
import com.intellij.openapi.util.Pair;
import com.intellij.psi.PsiAnchor;
import com.intellij.psi.PsiElement;
import com.intellij.psi.PsiFile;
import com.intellij.util.IncorrectOperationException;
@@ -40,7 +41,7 @@ import java.util.List;
public class CreatePropertyFix implements IntentionAction, LocalQuickFix {
private static final Logger LOG = Logger.getInstance("#com.intellij.codeInsight.i18n.I18nizeQuickFix");
private final PsiElement myElement;
private final PsiAnchor myElement;
private final String myKey;
private final List<PropertiesFile> myPropertiesFiles;
@@ -51,7 +52,7 @@ public class CreatePropertyFix implements IntentionAction, LocalQuickFix {
}
public CreatePropertyFix(PsiElement element, String key, final List<PropertiesFile> propertiesFiles) {
myElement = element;
myElement = element == null ? null : PsiAnchor.create(element);
myKey = key;
myPropertiesFiles = propertiesFiles;
}
@@ -79,11 +80,11 @@ public class CreatePropertyFix implements IntentionAction, LocalQuickFix {
}
public boolean isAvailable(@NotNull Project project, @Nullable Editor editor, @Nullable PsiFile file) {
return myElement.isValid();
return myElement != null && myElement.retrieve() != null;
}
public void invoke(@NotNull final Project project, @Nullable Editor editor, @NotNull PsiFile file) {
invokeAction(project, file, myElement, myKey, myPropertiesFiles);
invokeAction(project, file, myElement.retrieve(), myKey, myPropertiesFiles);
}
@Nullable