MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-18 09:34:34 +07:00
Code Issues Packages Projects Releases Wiki Activity

more early checks for the inspection running on unrelated file

Browse Source
This commit is contained in:
Alexey Kudravtsev
2017-02-27 15:18:16 +03:00
parent 9afdb0e181
commit db9552e1d9
7 changed files with 20 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files
plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/junit/JUnitAbstractTestClassNamingConventionInspectionBase.java
+5
View File
@@ -63,6 +63,11 @@ public class JUnitAbstractTestClassNamingConventionInspectionBase extends Conven
return new NamingConventionsVisitor();
}
@Override
public boolean shouldInspect(PsiFile file) {
return file instanceof PsiClassOwner;
}
private class NamingConventionsVisitor extends BaseInspectionVisitor {
@Override
plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/junit/JUnitTestClassNamingConventionInspectionBase.java
+5 -2
View File
@@ -17,12 +17,10 @@ package com.siyeh.ig.junit;
import com.intellij.codeInsight.TestFrameworks;
import com.intellij.psi.*;
import com.intellij.psi.util.InheritanceUtil;
import com.intellij.testIntegration.TestFramework;
import com.siyeh.InspectionGadgetsBundle;
import com.siyeh.ig.BaseInspectionVisitor;
import com.siyeh.ig.naming.ConventionInspection;
import com.siyeh.ig.psiutils.TestUtils;
import org.jetbrains.annotations.NotNull;
public class JUnitTestClassNamingConventionInspectionBase extends ConventionInspection {
@@ -66,6 +64,11 @@ public class JUnitTestClassNamingConventionInspectionBase extends ConventionInsp
return new NamingConventionsVisitor();
}
@Override
public boolean shouldInspect(PsiFile file) {
return file instanceof PsiClassOwner;
}
private class NamingConventionsVisitor extends BaseInspectionVisitor {
@Override
public void visitElement(PsiElement element) {
plugins/xpath/xpath-lang/src/org/intellij/lang/xpath/xslt/validation/inspections/TemplateInvocationInspection.java
+5 -10
View File
@@ -9,21 +9,15 @@ import com.intellij.psi.PsiElementVisitor;
import com.intellij.psi.XmlElementVisitor;
import com.intellij.psi.xml.XmlAttribute;
import com.intellij.psi.xml.XmlAttributeValue;
import com.intellij.psi.xml.XmlFile;
import com.intellij.psi.xml.XmlTag;
import org.jetbrains.annotations.NotNull;
import org.intellij.lang.xpath.xslt.XsltSupport;
import org.intellij.lang.xpath.xslt.psi.XsltApplyTemplates;
import org.intellij.lang.xpath.xslt.psi.XsltCallTemplate;
import org.intellij.lang.xpath.xslt.psi.XsltElementFactory;
import org.intellij.lang.xpath.xslt.psi.XsltParameter;
import org.intellij.lang.xpath.xslt.psi.XsltTemplate;
import org.intellij.lang.xpath.xslt.psi.XsltTemplateInvocation;
import org.intellij.lang.xpath.xslt.psi.XsltWithParam;
import org.intellij.lang.xpath.xslt.psi.*;
import org.intellij.lang.xpath.xslt.quickfix.AbstractFix;
import org.intellij.lang.xpath.xslt.quickfix.AddParameterFix;
import org.intellij.lang.xpath.xslt.quickfix.AddWithParamFix;
import org.intellij.lang.xpath.xslt.quickfix.RemoveParamFix;
import org.intellij.lang.xpath.xslt.quickfix.AbstractFix;
import org.jetbrains.annotations.NotNull;
import java.util.HashMap;
import java.util.Map;
@@ -52,6 +46,7 @@ public class TemplateInvocationInspection extends XsltInspection {
@NotNull
public PsiElementVisitor buildVisitor(@NotNull final ProblemsHolder holder, final boolean isOnTheFly) {
if (!(holder.getFile() instanceof XmlFile)) return PsiElementVisitor.EMPTY_VISITOR;
final XsltElementFactory xsltElementFactory = XsltElementFactory.getInstance();
return new XmlElementVisitor() {
@Override
plugins/xpath/xpath-lang/src/org/intellij/lang/xpath/xslt/validation/inspections/UnusedElementInspection.java
+2
View File
@@ -19,6 +19,7 @@ import com.intellij.codeInspection.ProblemsHolder;
import com.intellij.psi.PsiElementVisitor;
import com.intellij.psi.XmlElementVisitor;
import com.intellij.psi.xml.XmlAttribute;
import com.intellij.psi.xml.XmlFile;
import com.intellij.psi.xml.XmlTag;
import org.intellij.lang.xpath.xslt.XsltSupport;
import org.intellij.lang.xpath.xslt.psi.XsltElementFactory;
@@ -45,6 +46,7 @@ public class UnusedElementInspection extends XsltInspection {
@Override
@NotNull
public PsiElementVisitor buildVisitor(@NotNull final ProblemsHolder holder, boolean isOnTheFly) {
if (!(holder.getFile() instanceof XmlFile)) return PsiElementVisitor.EMPTY_VISITOR;
return new MyVisitor(holder);
}
plugins/xpath/xpath-lang/src/org/intellij/lang/xpath/xslt/validation/inspections/VariableShadowingInspection.java
+1
View File
@@ -55,6 +55,7 @@ public class VariableShadowingInspection extends XsltInspection {
@NotNull
public PsiElementVisitor buildVisitor(@NotNull final ProblemsHolder holder, final boolean isOnTheFly) {
if (!(holder.getFile() instanceof XmlFile)) return PsiElementVisitor.EMPTY_VISITOR;
return new XmlElementVisitor() {
@Override
public void visitXmlTag(final XmlTag tag) {
plugins/xpath/xpath-lang/src/org/intellij/lang/xpath/xslt/validation/inspections/XsltDeclarationInspection.java
+1
View File
@@ -47,6 +47,7 @@ public class XsltDeclarationInspection extends XsltInspection {
@NotNull
public PsiElementVisitor buildVisitor(@NotNull final ProblemsHolder holder, final boolean isOnTheFly) {
if (!(holder.getFile() instanceof XmlFile)) return PsiElementVisitor.EMPTY_VISITOR;
return new XmlElementVisitor() {
@Override
public void visitXmlTag(final XmlTag tag) {
python/src/com/jetbrains/python/inspections/PyPackageRequirementsInspection.java
+1
View File
@@ -70,6 +70,7 @@ public class PyPackageRequirementsInspection extends PyInspection {
public PsiElementVisitor buildVisitor(@NotNull ProblemsHolder holder,
boolean isOnTheFly,
@NotNull LocalInspectionToolSession session) {
if (!(holder.getFile() instanceof PyFile) && !(holder.getFile() instanceof PsiPlainTextFile)) return PsiElementVisitor.EMPTY_VISITOR;
return new Visitor(holder, session, ignoredPackages);
}