MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-10-01 17:03:12 +07:00
Code Issues Packages Projects Releases Wiki Activity

[RDCT] IJPL-162126: Fix availability hints exceptions

Browse Source 
`EditorActionAvailabilityHintHandler` adds hints on every highlighter update. If there is a highlighter with action availability hints and subsequent updates, these hints will be added multiple times, causing `logger.error`. The same happens in some other places like `InlinePromptHighlightingPassFactory` which may add hints several times.
This commit changes the assertion from "log error if there is a hint already" to "log error only if there is a *different* hint for this action". It skips already existing hints if they are exactly the same.

GitOrigin-RevId: 83e88ba3a050e291b5634341dd7526620623858f
This commit is contained in:
Vyacheslav Moklev
2024-10-09 17:02:47 +00:00
committed by intellij-monorepo-bot
parent e435d75b2b
commit db7891da87
1 changed files with 7 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
platform/editor-ui-ex/src/com/intellij/openapi/editor/ex/util/EditorActionAvailabilityHint.kt
+7 -3
View File
@@ -161,10 +161,14 @@ private fun UserDataHolderEx.addActionAvailabilityHintImpl(vararg newHints: Edit
putUserDataIfAbsent(hintsKey, hints)
}
for (newHint in newHints) {
if (hints.any { it.actionId == newHint.actionId }) {
logger.error("Availability hint for action '${newHint.actionId}' already exists")
return
val existingHint = hints.find { it.actionId == newHint.actionId }
if (existingHint != null) {
if (existingHint.condition != newHint.condition) {
logger.error("Availability hint for action '${newHint.actionId}' already exists")
}
continue
}
hints.add(newHint)
}
}