MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-04-20 13:31:28 +07:00
Code Issues Packages Projects Releases Wiki Activity

[java] returns type parameter name to "missing tag" warning

Browse Source
This commit is contained in:
Roman Shevchenko
2018-06-15 12:19:29 +03:00
parent 7c5a344c83
commit dad46c21f1
2 changed files with 11 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
java/java-analysis-impl/src/com/intellij/codeInspection/javaDoc/JavadocHighlightUtil.java
View File

@@ -1,4 +1,4 @@
// Copyright 2000-2017 JetBrains s.r.o. Use of this source code is governed by the Apache 2.0 license that can be found in the LICENSE file.
// Copyright 2000-2018 JetBrains s.r.o. Use of this source code is governed by the Apache 2.0 license that can be found in the LICENSE file.
package com.intellij.codeInspection.javaDoc;
import com.intellij.codeInspection.InspectionsBundle;
@@ -323,14 +323,14 @@ public class JavadocHighlightUtil {
});
}
static void checkMissingTypeParamTags(@NotNull PsiTypeParameterListOwner parameterListOwner,
static void checkMissingTypeParamTags(@NotNull PsiTypeParameterListOwner owner,
@NotNull PsiDocTag[] tags,
@NotNull PsiElement toHighlight,
@NotNull ProblemHolder holder) {
if (parameterListOwner.hasTypeParameters()) {
if (owner.hasTypeParameters()) {
List<PsiTypeParameter> absentParameters = null;
for (PsiTypeParameter typeParameter : parameterListOwner.getTypeParameters()) {
for (PsiTypeParameter typeParameter : owner.getTypeParameters()) {
if (!hasTagForParameter(tags, typeParameter)) {
(absentParameters = list(absentParameters)).add(typeParameter);
}
@@ -338,8 +338,12 @@ public class JavadocHighlightUtil {
if (absentParameters != null) {
for (PsiTypeParameter typeParameter : absentParameters) {
String message = InspectionsBundle.message("inspection.javadoc.problem.missing.tag", "<code>@param</code>");
holder.problem(toHighlight, message, holder.addMissingTagFix("param", "<" + typeParameter.getName() + ">"));
String name = typeParameter.getName();
if (name != null) {
String tagText = "<code>&lt;" + name + "&gt;</code>";
String message = InspectionsBundle.message("inspection.javadoc.method.problem.missing.param.tag", tagText);
holder.problem(toHighlight, message, holder.addMissingTagFix("param", "<" + name + ">"));
}
}
}
}

3
java/java-tests/testData/codeInsight/daemonCodeAnalyzer/javaDoc/TypeParam.java
View File

@@ -1,6 +1,5 @@
class Test {
<warning descr="Required tag '@param' is missing">/**</warning>
<warning descr="Required tag '@param' is missing for parameter '<T>'">/**</warning>
* period.
*/
public <T> void f() {}