[java-inspections] Java8MapForEachInspection: disable when entry getter is used in void context

Also avoid replacing expression with identifier, as this creates illegal PSI
Fixes EA-537547 - IOE: PsiExpressionStatementImpl.replaceChildInternal

GitOrigin-RevId: 7fd9c0f98165a2f5b6ad74154fa1b5b701610ee7

java/java-impl-inspections/src/com/intellij/codeInspection/java18api/Java8MapForEachInspection.java

@@ -73,7 +73,7 @@ public class Java8MapForEachInspection extends AbstractBaseJavaLocalInspectionTo
         return ReferencesSearch.search(entry).allMatch(entryRef -> {
           PsiMethodCallExpression entryCall =
             ExpressionUtils.getCallForQualifier(ObjectUtils.tryCast(entryRef.getElement(), PsiExpression.class));
-          return ENTRY_GETTER.test(entryCall);
+          return ENTRY_GETTER.test(entryCall) && !ExpressionUtils.isVoidContext(entryCall);
         });
       }
 
@@ -164,7 +164,7 @@ public class Java8MapForEachInspection extends AbstractBaseJavaLocalInspectionTo
         if (!expression.isValid()) continue;
         PsiMethodCallExpression entryCall = ExpressionUtils.getCallForQualifier(expression);
         if (ENTRY_GETTER.test(entryCall)) {
-          ct.replace(entryCall, factory.createIdentifier(ParameterCandidate.select(entryCall, key, value).myName));
+          ct.replace(entryCall, ParameterCandidate.select(entryCall, key, value).myName);
         }
       }
       String lambdaBody;

java/java-tests/testData/inspection/java8MapForEach/afterForEach.java

@@ -92,4 +92,11 @@ public class Test {
           //long comment
       });
   }
+
+  void expressionStatement(Map<String, String> map) {
+    for (Map.Entry<String, String> entry : map.entrySet()) {
+      String value = entry.getValue();
+      entry.getValue();
+    }
+  }
 }

java/java-tests/testData/inspection/java8MapForEach/beforeForEach.java

@@ -114,4 +114,11 @@ public class Test {
       //long comment
     }
   }
+
+  void expressionStatement(Map<String, String> map) {
+    for (Map.Entry<String, String> entry : map.entrySet()) {
+      String value = entry.getValue();
+      entry.getValue();
+    }
+  }
 }