MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-27 10:03:11 +07:00
Code Issues Packages Projects Releases Wiki Activity

PY-18816 Use PyResolveContext#noImplicits() instead of defaultContext()

Browse Source 
where resolving of implicit attributes is actually not required.
Originally, defaultContext() was intended to be only for
"Navigate to Definition".
This commit is contained in:
Mikhail Golubev
2017-07-19 19:28:31 +03:00
parent db7524e353
commit d93fef967b
4 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
python/src/com/jetbrains/python/inspections/PyGlobalUndefinedInspection.java
+1 -1
View File
@@ -58,7 +58,7 @@ public class PyGlobalUndefinedInspection extends PyInspection {
final PyTargetExpression[] globals = node.getGlobals();
for (PyTargetExpression global : globals) {
final PyResolveContext resolveContext = PyResolveContext.defaultContext().withTypeEvalContext(myTypeEvalContext);
final PyResolveContext resolveContext = PyResolveContext.noImplicits().withTypeEvalContext(myTypeEvalContext);
if (global.getReference(resolveContext).resolve() == global) {
registerProblem(global, PyBundle.message("INSP.NAME.global.$0.undefined", global.getName()));
}
python/src/com/jetbrains/python/psi/impl/PyNamedParameterImpl.java
+1 -1
View File
@@ -398,7 +398,7 @@ public class PyNamedParameterImpl extends PyBaseElementImpl<PyNamedParameterStub
public void visitPyTargetExpression(PyTargetExpression node) {
if (parameterWasReassigned.get()) return;
final PyResolveContext resolveContext = PyResolveContext.defaultContext().withTypeEvalContext(context);
final PyResolveContext resolveContext = PyResolveContext.noImplicits().withTypeEvalContext(context);
if (node.getReference(resolveContext).isReferenceTo(PyNamedParameterImpl.this)) {
parameterWasReassigned.set(true);
}
python/src/com/jetbrains/python/refactoring/classes/membersManager/InstanceFieldsManager.java
+1 -1
View File
@@ -136,7 +136,7 @@ class InstanceFieldsManager extends FieldsManager {
@Override
protected boolean applyNotNull(@NotNull final PyTargetExpression input) {
final TypeEvalContext typeEvalContext = TypeEvalContext.userInitiated(input.getProject(), null);
final PyResolveContext context = PyResolveContext.defaultContext().withTypeEvalContext(typeEvalContext);
final PyResolveContext context = PyResolveContext.noImplicits().withTypeEvalContext(typeEvalContext);
return input.getReference(context).resolve() instanceof PyTargetExpression;
}
}
python/src/com/jetbrains/python/refactoring/classes/membersManager/PropertiesManager.java
+1 -1
View File
@@ -190,7 +190,7 @@ class PropertiesManager extends MembersManager<PyElement> {
final PsiReference reference;
if (node instanceof PyReferenceOwner) {
final TypeEvalContext context = TypeEvalContext.userInitiated(node.getProject(), null);
reference = ((PyReferenceOwner)node).getReference(PyResolveContext.defaultContext().withTypeEvalContext(context));
reference = ((PyReferenceOwner)node).getReference(PyResolveContext.noImplicits().withTypeEvalContext(context));
}
else {
reference = node.getReference();