MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-27 10:03:11 +07:00
Code Issues Packages Projects Releases Wiki Activity

Remove unnecessary synchronization.

Browse Source
This commit is contained in:
Sergey Evdokimov
2012-03-13 19:00:35 +04:00
parent 1a32dcffa7
commit d846dd6e49
1 changed files with 15 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files
plugins/groovy/src/org/jetbrains/plugins/groovy/mvc/MvcModuleStructureSynchronizer.java
+15 -22
View File
@@ -242,22 +242,21 @@ public class MvcModuleStructureSynchronizer extends AbstractProjectComponent {
private void queue(SyncAction action, Object on) {
ApplicationManager.getApplication().assertIsDispatchThread();
synchronized (myActions) {
if (myActions.isEmpty()) {
if (myProject.isDisposed()) return;
StartupManager.getInstance(myProject).runWhenProjectIsInitialized(new DumbAwareRunnable() {
public void run() {
ApplicationManager.getApplication().invokeLater(new Runnable() {
public void run() {
runActions();
}
}, ModalityState.NON_MODAL);
}
});
}
myActions.add(new Pair<Object, SyncAction>(on, action));
if (myActions.isEmpty()) {
if (myProject.isDisposed()) return;
StartupManager.getInstance(myProject).runWhenProjectIsInitialized(new DumbAwareRunnable() {
public void run() {
ApplicationManager.getApplication().invokeLater(new Runnable() {
public void run() {
runActions();
}
}, ModalityState.NON_MODAL);
}
});
}
myActions.add(new Pair<Object, SyncAction>(on, action));
}
@NotNull
@@ -289,16 +288,12 @@ public class MvcModuleStructureSynchronizer extends AbstractProjectComponent {
private void runActions() {
try {
ApplicationManager.getApplication().assertIsDispatchThread();
if (myProject.isDisposed()) {
return;
}
Pair<Object, SyncAction>[] actions;
Pair<Object, SyncAction>[] actions = myActions.toArray(new Pair[myActions.size()]);
//get module by object and kill duplicates
synchronized (myActions) {
actions = myActions.toArray(new Pair[myActions.size()]);
}
final Set<Trinity<Module, SyncAction, MvcFramework>> rawActions = new LinkedHashSet<Trinity<Module, SyncAction, MvcFramework>>();
@@ -336,9 +331,7 @@ public class MvcModuleStructureSynchronizer extends AbstractProjectComponent {
// if there were any actions added during performSyncAction, clear them too
// all needed actions are already added to buffer and have thus been performed
// otherwise you may get repetitive 'run create-app?' questions
synchronized (myActions) {
myActions.clear();
}
myActions.clear();
}
}