PY-624

Unused assignment false positive

python/src/com/jetbrains/python/codeInsight/controlflow/PyControlFlowBuilder.java

@@ -441,6 +441,11 @@ public class PyControlFlowBuilder extends PyRecursiveElementVisitor {
 
   @Override
   public void visitPyListCompExpression(final PyListCompExpression node) {
+    visitPyGeneratorExpression(node);
+  }
+
+  @Override
+  public void visitPyGeneratorExpression(final PyGeneratorExpression node) {
     myBuilder.startNode(node);
     PyExpression prevCondition = null;
     for (ComprhIfComponent component : node.getIfComponents()) {

python/src/com/jetbrains/python/psi/PyListCompExpression.java

@@ -23,8 +23,5 @@ import java.util.List;
  * User: yole
  * Date: 31.05.2005
  */
-public interface PyListCompExpression extends PyExpression, NameDefiner {
-  PyExpression getResultExpression();
-  List<ComprhForComponent> getForComponents();
-  List<ComprhIfComponent> getIfComponents();
+public interface PyListCompExpression extends PyGeneratorExpression {
 }

python/testData/codeInsight/controlflow/returnfor.py

@@ -0,0 +1 @@
+return dict((name, val) for name, val in {'a': 1})

python/testData/codeInsight/controlflow/returnfor.txt

@@ -0,0 +1,9 @@
+0(1) element: null
+1(2) element: PyReturnStatement
+2(3) READ ACCESS: dict
+3(4) element: PyGeneratorExpression
+4(5) WRITE ACCESS: name
+5(6) WRITE ACCESS: val
+6(7) READ ACCESS: name
+7(8) READ ACCESS: val
+8() element: null

python/testData/codeInsight/controlflow/try.txt

@@ -14,7 +14,7 @@
 13(14) READ ACCESS: int
 14(15) READ ACCESS: s
 15(16) READ ACCESS: strip
-16(17,25,28,33) WRITE ACCESS: i
+16(17,25,28,34) WRITE ACCESS: i
 17(18) element: PyExceptPart
 18(19) READ ACCESS: IOError
 19(20) WRITE ACCESS: errno
@@ -22,13 +22,14 @@
 21(22) element: PyPrintStatement
 22(23) READ ACCESS: format
 23(24) READ ACCESS: errno
-24(33) READ ACCESS: strerror
+24(34) READ ACCESS: strerror
 25(26) element: PyExceptPart
 26(27) READ ACCESS: ValueError
-27(33) element: PyPrintStatement
+27(34) element: PyPrintStatement
 28(29) element: PyExceptPart
 29(30) element: PyPrintStatement
-30(31) READ ACCESS: sys
-31(32) READ ACCESS: exc_info
-32(33) element: PyRaiseStatement
-33() element: null
+30(31) element: PySubscriptionExpression
+31(32) READ ACCESS: sys
+32(33) READ ACCESS: exc_info
+33(34) element: PyRaiseStatement
+34() element: null

python/testSrc/com/jetbrains/python/PyControlFlowBuilderTest.java

@@ -86,6 +86,10 @@ public class PyControlFlowBuilderTest extends LightMarkedTestCase {
     doTest();
   }
 
+  public void testReturnFor() throws Exception {
+    doTest();
+  }
+
   public void testTryBreak() throws Exception {
     final String testName = getTestName(false).toLowerCase();
     configureByFile(testName + ".py");