MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-27 10:03:11 +07:00
Code Issues Packages Projects Releases Wiki Activity

cleanup: mark read/writeExternal in FacetConfiguration as default

Browse Source 
And remove empty implementations.
This commit is contained in:
nik
2017-12-21 19:55:11 +03:00
parent 99a8d22351
commit d6fc5cd95b
3 changed files with 6 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files
platform/lang-api/src/com/intellij/facet/FacetConfiguration.java
+4 -2
View File
@@ -48,12 +48,14 @@ public interface FacetConfiguration extends JDOMExternalizable {
*/
@Override
@Deprecated
void readExternal(final Element element) throws InvalidDataException;
default void readExternal(final Element element) throws InvalidDataException {
}
/**
* @deprecated implement {@link com.intellij.openapi.components.PersistentStateComponent#getState()} instead
*/
@Override
@Deprecated
void writeExternal(final Element element) throws WriteExternalException;
default void writeExternal(final Element element) throws WriteExternalException {
}
}
platform/lang-impl/src/com/intellij/facet/impl/invalid/InvalidFacetConfiguration.java
+2 -13
View File
@@ -16,14 +16,11 @@
package com.intellij.facet.impl.invalid;
import com.intellij.facet.FacetConfiguration;
import org.jetbrains.annotations.NotNull;
import org.jetbrains.jps.model.serialization.facet.FacetState;
import com.intellij.facet.ui.FacetEditorContext;
import com.intellij.facet.ui.FacetEditorTab;
import com.intellij.facet.ui.FacetValidatorsManager;
import com.intellij.openapi.util.InvalidDataException;
import com.intellij.openapi.util.WriteExternalException;
import org.jdom.Element;
import org.jetbrains.annotations.NotNull;
import org.jetbrains.jps.model.serialization.facet.FacetState;
/**
* @author nik
@@ -49,14 +46,6 @@ public class InvalidFacetConfiguration implements FacetConfiguration {
};
}
@Override
public void readExternal(Element element) throws InvalidDataException {
}
@Override
public void writeExternal(Element element) throws WriteExternalException {
}
public String getErrorMessage() {
return myErrorMessage;
}
plugins/google-app-engine/source/com/intellij/appengine/facet/AppEngineFacetConfiguration.java
-9
View File
@@ -20,9 +20,6 @@ import com.intellij.facet.ui.FacetEditorContext;
import com.intellij.facet.ui.FacetEditorTab;
import com.intellij.facet.ui.FacetValidatorsManager;
import com.intellij.openapi.components.PersistentStateComponent;
import com.intellij.openapi.util.InvalidDataException;
import com.intellij.openapi.util.WriteExternalException;
import org.jdom.Element;
import org.jetbrains.jps.appengine.model.PersistenceApi;
import org.jetbrains.jps.appengine.model.impl.AppEngineModuleExtensionProperties;
@@ -40,12 +37,6 @@ public class AppEngineFacetConfiguration implements FacetConfiguration, Persiste
};
}
public void readExternal(Element element) throws InvalidDataException {
}
public void writeExternal(Element element) throws WriteExternalException {
}
public AppEngineModuleExtensionProperties getState() {
return myProperties;
}