MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-27 10:03:11 +07:00
Code Issues Packages Projects Releases Wiki Activity

IG: don't try to convert hex and octal to float literal (IDEA-186852)

Browse Source
This commit is contained in:
Bas Leijdekkers
2018-02-18 15:41:37 +01:00
parent e9f93ef9e8
commit d6f4db2b1b
2 changed files with 20 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/migration/UnnecessaryBoxingInspection.java
+8 -6
View File
@@ -138,12 +138,14 @@ public class UnnecessaryBoxingInspection extends BaseInspection {
if (unboxedType.equals(PsiType.LONG) && expressionType.equals(PsiType.INT)) {
return text + 'L';
}
else if (unboxedType.equals(PsiType.FLOAT) && (expressionType.equals(PsiType.INT) || (expressionType.equals(PsiType.DOUBLE)) &&
!StringUtil.endsWithIgnoreCase(text, "d"))) {
return text + 'f';
}
else if (unboxedType.equals(PsiType.DOUBLE) && expressionType.equals(PsiType.INT)) {
return text + 'd';
else if (!text.startsWith("0")) { // no octal & hex
if (unboxedType.equals(PsiType.FLOAT) && (expressionType.equals(PsiType.INT) || (expressionType.equals(PsiType.DOUBLE)) &&
!StringUtil.endsWithIgnoreCase(text, "d"))) {
return text + 'f';
}
else if (unboxedType.equals(PsiType.DOUBLE) && expressionType.equals(PsiType.INT)) {
return text + 'd';
}
}
}
if (ParenthesesUtils.getPrecedence(unboxedExpression) > ParenthesesUtils.TYPE_CAST_PRECEDENCE) {
plugins/InspectionGadgets/testsrc/com/siyeh/ig/fixes/migration/UnnecessaryBoxingFixTest.java
+12
View File
@@ -74,6 +74,18 @@ public class UnnecessaryBoxingFixTest extends IGQuickFixesTestCase {
"\"a\" + (1L - 2L) + \"b\"");
}
public void testHex() {
doMemberTest(InspectionGadgetsBundle.message("unnecessary.boxing.remove.quickfix"),
"float f = Float./**/valueOf(0x123);",
"float f = (float) 0x123;");
}
public void testOctal() {
doMemberTest(InspectionGadgetsBundle.message("unnecessary.boxing.remove.quickfix"),
"float f = Float.valueOf/**/(0123);",
"float f = (float) 0123;");
}
public void testCast() {
doFixTest();
}