MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-27 10:03:11 +07:00
Code Issues Packages Projects Releases Wiki Activity

IDEA-178462 Parameter info in tooltip for @Deprecated method

Browse Source
This commit is contained in:
Dmitry Batrak
2017-09-08 13:10:46 +03:00
parent e1e3f9c871
commit d64f741ae5
6 changed files with 23 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
java/java-impl/src/com/intellij/codeInsight/hint/api/impls/MethodParameterInfoHandler.java
+1 -1
View File
@@ -630,7 +630,7 @@ public class MethodParameterInfoHandler implements ParameterInfoHandlerWithTabAc
highlightStartOffset,
highlightEndOffset,
!context.isUIComponentEnabled(),
method.isDeprecated() && !context.isSingleParameterInfo(),
method.isDeprecated() && !context.isSingleParameterInfo() && !context.isSingleOverload(),
false,
context.getDefaultParameterColor()
);
java/java-tests/testSrc/com/intellij/java/codeInsight/ParameterInfoTest.java
+6
View File
@@ -22,6 +22,7 @@ import com.intellij.codeInsight.hint.api.impls.AnnotationParameterInfoHandler;
import com.intellij.codeInsight.hint.api.impls.MethodParameterInfoHandler;
import com.intellij.codeInsight.lookup.LookupElement;
import com.intellij.codeInsight.lookup.LookupElementPresentation;
import com.intellij.ide.highlighter.JavaFileType;
import com.intellij.lang.parameterInfo.CreateParameterInfoContext;
import com.intellij.lang.parameterInfo.ParameterInfoUIContextEx;
import com.intellij.openapi.util.Disposer;
@@ -296,6 +297,11 @@ public class ParameterInfoTest extends LightCodeInsightFixtureTestCase {
checkHighlighted(0);
}
public void testNoStrikeoutForSingleDeprecatedMethod() {
myFixture.configureByText(JavaFileType.INSTANCE, "class C { void m() { System.runFinalizersOnExit(true<caret>); } }");
assertEquals("<html>boolean value</html>", parameterPresentation(-1));
}
private void checkHighlighted(int lineIndex) {
MethodParameterInfoHandler handler = new MethodParameterInfoHandler();
CreateParameterInfoContext context = createContext();
platform/lang-api/src/com/intellij/lang/parameterInfo/ParameterInfoUIContext.java
+1
View File
@@ -29,6 +29,7 @@ public interface ParameterInfoUIContext {
int getCurrentParameterIndex();
PsiElement getParameterOwner();
boolean isSingleOverload();
boolean isSingleParameterInfo();
Color getDefaultParameterColor();
}
platform/lang-impl/src/com/intellij/codeInsight/hint/ParameterInfoComponent.java
+5
View File
@@ -210,6 +210,11 @@ public class ParameterInfoComponent extends JPanel {
return myParameterOwner;
}
@Override
public boolean isSingleOverload() {
return myPanels.length == 1;
}
@Override
public boolean isSingleParameterInfo() {
return mySingleParameterInfo;
platform/testFramework/src/com/intellij/testFramework/utils/parameterInfo/MockParameterInfoUIContext.java
+5
View File
@@ -69,6 +69,11 @@ public class MockParameterInfoUIContext<T extends PsiElement> implements Paramet
return myFunction;
}
@Override
public boolean isSingleOverload() {
return false;
}
@Override
public boolean isSingleParameterInfo() {
return false;
python/testSrc/com/jetbrains/python/PyParameterInfoTest.java
+5
View File
@@ -819,6 +819,11 @@ public class PyParameterInfoTest extends LightMarkedTestCase {
return myParameterOwner;
}
@Override
public boolean isSingleOverload() {
return myItemsToShow.length == 1;
}
@Override
public boolean isSingleParameterInfo() {
return false;