MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-27 10:03:11 +07:00
Code Issues Packages Projects Releases Wiki Activity

CredentialStore: fix empty-string username removal

Browse Source
This commit is contained in:
Alexander Kass
2019-01-31 17:05:14 +03:00
parent 45592302ee
commit d5c0ca7425
2 changed files with 19 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
platform/credential-store/src/keePass/BaseKeePassCredentialStore.kt
+1 -1
View File
@@ -25,7 +25,7 @@ internal abstract class BaseKeePassCredentialStore : CredentialStore {
override fun set(attributes: CredentialAttributes, credentials: Credentials?) {
if (credentials == null) {
db.rootGroup.getGroup(ROOT_GROUP_NAME)?.removeEntry(attributes.serviceName, attributes.userName)
db.rootGroup.getGroup(ROOT_GROUP_NAME)?.removeEntry(attributes.serviceName, attributes.userName.nullize())
}
else {
val group = db.rootGroup.getOrCreateGroup(ROOT_GROUP_NAME)
platform/credential-store/test/CredentialStoreTest.kt
+18
View File
@@ -60,6 +60,11 @@ internal class CredentialStoreTest {
testEmptyAccountName(InMemoryCredentialStore())
}
@Test
fun `KeePass - testEmptyStrAccountName`() {
testEmptyStrAccountName(InMemoryCredentialStore())
}
@Test
fun `KeePass - changedAccountName`() {
testChangedAccountName(InMemoryCredentialStore())
@@ -135,6 +140,19 @@ internal class CredentialStoreTest {
}
}
private fun testEmptyStrAccountName(store: CredentialStore) {
val attributes = CredentialAttributes("Test IJ — ${randomString()}", "")
try {
val credentials = Credentials("", "pass")
store.set(attributes, credentials)
assertThat(store.get(attributes)).isEqualTo(credentials)
}
finally {
store.set(attributes, null)
}
assertThat(store.get(attributes)).isNull()
}
private fun testChangedAccountName(store: CredentialStore) {
val serviceNameOnlyAttributes = CredentialAttributes("Test IJ — ${randomString()}")
try {