MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-27 10:03:11 +07:00
Code Issues Packages Projects Releases Wiki Activity

[coverage] Refactor pass CoverageRunner in constructor instead of setter

Browse Source 
GitOrigin-RevId: 44916a57f7f71d610b3815dad6c870a21d157807
This commit is contained in:
Maksim Zuev
2023-12-19 17:24:12 +00:00
committed by intellij-monorepo-bot
parent fa3b739293
commit d553ff0c92
2 changed files with 17 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
plugins/coverage-common/src/com/intellij/execution/configurations/coverage/CoverageEnabledConfiguration.java
+15 -1
View File
@@ -41,10 +41,20 @@ public abstract class CoverageEnabledConfiguration implements JDOMExternalizable
protected @NonNls String myCoverageFilePath;
private CoverageSuite myCurrentCoverageSuite;
/**
*
* @deprecated Use {@link CoverageEnabledConfiguration#CoverageEnabledConfiguration(RunConfigurationBase, CoverageRunner)}
*/
@Deprecated
public CoverageEnabledConfiguration(@NotNull RunConfigurationBase<?> configuration) {
myConfiguration = configuration;
}
public CoverageEnabledConfiguration(@NotNull RunConfigurationBase<?> configuration, @NotNull CoverageRunner runner) {
myConfiguration = configuration;
myCoverageRunner = runner;
}
public @NotNull RunConfigurationBase<?> getConfiguration() {
return myConfiguration;
}
@@ -57,7 +67,11 @@ public abstract class CoverageEnabledConfiguration implements JDOMExternalizable
return myCoverageRunner;
}
public void setCoverageRunner(final @Nullable CoverageRunner coverageRunner) {
/**
* @deprecated Use {@link CoverageEnabledConfiguration#CoverageEnabledConfiguration(RunConfigurationBase, CoverageRunner)}
*/
@Deprecated
public void setCoverageRunner(@Nullable CoverageRunner coverageRunner) {
myCoverageRunner = coverageRunner;
myCoverageFilePath = null;
}
plugins/coverage/src/com/intellij/execution/configurations/coverage/JavaCoverageEnabledConfiguration.java
+2 -2
View File
@@ -25,6 +25,7 @@ import java.nio.file.Path;
import java.nio.file.Paths;
import java.util.ArrayList;
import java.util.List;
import java.util.Objects;
/**
* Base class for java run configurations with enabled code coverage
@@ -41,8 +42,7 @@ public final class JavaCoverageEnabledConfiguration extends CoverageEnabledConfi
public JavaCoverageEnabledConfiguration(RunConfigurationBase configuration) {
super(configuration);
setCoverageRunner(CoverageRunner.getInstance(IDEACoverageRunner.class));
super(configuration, Objects.requireNonNull(CoverageRunner.getInstance(IDEACoverageRunner.class)));
}
public void downloadReport(@NotNull TargetEnvironment environment, @NotNull ProgressIndicator indicator) throws IOException {