MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-27 10:03:11 +07:00
Code Issues Packages Projects Releases Wiki Activity

IG: check if type is assignable (IDEA-199613)

Browse Source
This commit is contained in:
Bas Leijdekkers
2018-09-28 18:18:41 +02:00
parent c7f9300541
commit d4c560f670
2 changed files with 27 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files
plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/dataflow/ConstantValueVariableUseInspection.java
+19 -12
View File
@@ -1,5 +1,5 @@
/*
* Copyright 2008-2015 Bas Leijdekkers
* Copyright 2008-2018 Bas Leijdekkers
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -153,16 +153,16 @@ public class ConstantValueVariableUseInspection extends BaseInspection implement
return false;
}
private boolean checkConstantValueVariableUse(
@Nullable PsiExpression expression,
@NotNull PsiExpression constantExpression,
@NotNull PsiElement body) {
private boolean checkConstantValueVariableUse(@Nullable PsiExpression expression,
@NotNull PsiExpression constantExpression,
@NotNull PsiElement body) {
final PsiType constantType = constantExpression.getType();
if (constantType == null) {
return false;
}
if (PsiType.DOUBLE.equals(constantType)) {
final Object result = ExpressionUtils.computeConstantExpression(
constantExpression, false);
if (Double.valueOf(0.0).equals(result) ||
Double.valueOf(-0.0).equals(result)) {
final Object result = ExpressionUtils.computeConstantExpression(constantExpression, false);
if (Double.valueOf(0.0).equals(result) || Double.valueOf(-0.0).equals(result)) {
return false;
}
}
@@ -170,8 +170,7 @@ public class ConstantValueVariableUseInspection extends BaseInspection implement
if (!(expression instanceof PsiReferenceExpression)) {
return false;
}
final PsiReferenceExpression referenceExpression =
(PsiReferenceExpression)expression;
final PsiReferenceExpression referenceExpression = (PsiReferenceExpression)expression;
final PsiElement target = referenceExpression.resolve();
if (!(target instanceof PsiVariable)) {
return false;
@@ -185,7 +184,15 @@ public class ConstantValueVariableUseInspection extends BaseInspection implement
if (!visitor.isRead()) {
return false;
}
registerError(visitor.getReference(), constantExpression);
final PsiReferenceExpression reference = visitor.getReference();
final PsiType referenceType = reference.getType();
if (referenceType == null) {
return false;
}
if (!referenceType.isAssignableFrom(constantType)) {
return false;
}
registerError(reference, constantExpression);
return true;
}
}
plugins/InspectionGadgets/test/com/siyeh/igtest/dataflow/constant_value_variable_use/ConstantValueVariableUse.java
+8
View File
@@ -58,4 +58,12 @@ class D {
}
}
}
private <T> T foo(Class<T> type) {
T result = null;
if (type == Boolean.class) {
result = type.cast( true);
}
return result;
}
}