type migration: fix type parameter migration for invalid code EA-100944

java/java-impl/src/com/intellij/refactoring/typeMigration/rules/RootTypeConversionRule.java

@@ -166,6 +166,7 @@ public class RootTypeConversionRule extends TypeConversionRule {
       }
       throw new AssertionError(" migrationType: " + migrationType + ", paramId: " + paramId + ", actualParameters: " + Arrays.toString(actualParams));
     } else {
+      if (paramId >= actualParams.length) return true;
       return TypeConversionUtil.areTypesAssignmentCompatible(migrationType, actualParams[paramId]);
     }
   }

java/typeMigration/test/com/intellij/refactoring/TypeMigrationTest.java

@@ -870,6 +870,10 @@ public class TypeMigrationTest extends TypeMigrationTestBase {
     doTestFieldType("migrationField", myJavaFacade.getElementFactory().createTypeFromText("Test<Short>", null));
   }
 
+  public void testTypeParameterMigrationInInvalidCode() {
+    doTestFieldType("migrationField", myJavaFacade.getElementFactory().createTypeFromText("Test<Short>", null));
+  }
+
   private void doTestReturnType(final String methodName, final String migrationType) {
     start(new RulesProvider() {
       @Override

java/typeMigration/testData/refactoring/typeMigration/typeParameterMigrationInInvalidCode/after/Test.items

@@ -0,0 +1,10 @@
+Types:
+PsiField:migrationField : Test<java.lang.Short>
+PsiMethodCallExpression:migrationField.method() : void
+PsiReferenceExpression:migrationField : Test<java.lang.Short>
+
+Conversions:
+migrationField.method() -> $
+
+New expression type changes:
+Fails:

java/typeMigration/testData/refactoring/typeMigration/typeParameterMigrationInInvalidCode/after/test.java

@@ -0,0 +1,11 @@
+class Test<X> {
+    private static Test<Short> migrationField;
+
+    private static void m(Short x1, Short x2) {
+        migrationField.method();
+    }
+
+    void method(X[] xes) {
+
+    }
+}

java/typeMigration/testData/refactoring/typeMigration/typeParameterMigrationInInvalidCode/before/test.java

@@ -0,0 +1,11 @@
+class Test<X> {
+    private static Test<Number> migrationField;
+
+    private static void m(Short x1, Short x2) {
+        migrationField.method();
+    }
+
+    void method(X[] xes) {
+
+    }
+}