check for list size: skiped varargs parameter (16666)

java/java-impl/src/com/intellij/refactoring/changeSignature/ChangeSignatureUtil.java

@@ -43,7 +43,7 @@ public class ChangeSignatureUtil {
       if (elementsToRemove == null) {
         elementsToRemove = new ArrayList<Child>();
         for (int i = 0; i < shouldRemoveChild.length; i++) {
-          if (shouldRemoveChild[i]) {
+          if (shouldRemoveChild[i] && i < elements.size()) {
             elementsToRemove.add(elements.get(i));
           }
         }

java/java-tests/testData/refactoring/changeSignature/RemoveVarargParameter.java

@@ -0,0 +1,12 @@
+class Test {
+   void fo<caret>o(int i, int ... ja){
+    }
+
+    void bar() {
+      foo(0);
+      foo(0, 1);
+      foo(0, 1, 2);
+      foo(0, new int[]{3, 4});
+      foo(0, new int[0]);
+    }
+}

java/java-tests/testData/refactoring/changeSignature/RemoveVarargParameter_after.java

@@ -0,0 +1,12 @@
+class Test {
+   void foo(int i){
+    }
+
+    void bar() {
+      foo(0);
+      foo(0);
+      foo(0);
+      foo(0);
+      foo(0);
+    }
+}

java/java-tests/testSrc/com/intellij/refactoring/ChangeSignatureTest.java

@@ -129,6 +129,10 @@ public class ChangeSignatureTest extends LightCodeInsightTestCase {
     }, false);
   }
 
+  public void testRemoveVarargParameter() throws Exception {
+    doTest(null, null, null, new ParameterInfoImpl[]{new ParameterInfoImpl(0)}, new ThrownExceptionInfo[0], false);
+  }
+
   public void testEnumConstructor() throws Exception {
     doTest(null, new ParameterInfoImpl[] {
       new ParameterInfoImpl(-1, "i", PsiType.INT, "10")