mirror of
https://gitflic.ru/project/openide/openide.git
synced 2026-09-27 10:03:11 +07:00
PY-6955 Unused import not greyed out if also failing
This commit is contained in:
@@ -984,6 +984,10 @@ public class PyUnresolvedReferencesInspection extends PyInspection {
|
||||
final PyImportElement importElement = (PyImportElement)unusedImport;
|
||||
final PsiElement element = importElement.resolve();
|
||||
if (element == null) {
|
||||
if (importElement.getImportedQName() != null) {
|
||||
//Mark import as unused even if it can't be resolved
|
||||
result.add(importElement.getParent());
|
||||
}
|
||||
continue;
|
||||
}
|
||||
if (dunderAll != null && dunderAll.contains(importElement.getVisibleName())) {
|
||||
|
||||
+2
@@ -1 +1,3 @@
|
||||
from importSource import <error descr="Unresolved reference 'len'">len</error>
|
||||
|
||||
len()
|
||||
|
||||
+1
@@ -0,0 +1 @@
|
||||
<warning descr="Unused import statement">from my_module import <error descr="Unresolved reference 'eggs'">eggs</error></warning>
|
||||
+2
@@ -0,0 +1,2 @@
|
||||
def my_func():
|
||||
pass
|
||||
+2
@@ -0,0 +1,2 @@
|
||||
<warning descr="Unused import statement">from my_module import <error descr="Unresolved reference 'eggs'">eggs</error></warning>
|
||||
<warning descr="Unused import statement">from my_module import <error descr="Unresolved reference 'eggs'">eggs</error></warning>
|
||||
+2
@@ -0,0 +1,2 @@
|
||||
def my_func():
|
||||
pass
|
||||
+4
@@ -0,0 +1,4 @@
|
||||
from my_package.my_module import <error descr="Unresolved reference 'eggs'">eggs</error>
|
||||
from my_package.my_module import <error descr="Unresolved reference 'eggs'">eggs</error>
|
||||
|
||||
eggs()
|
||||
+1
@@ -0,0 +1 @@
|
||||
__author__ = 'Ilya.Kazakevich'
|
||||
+2
@@ -0,0 +1,2 @@
|
||||
def my_func():
|
||||
pass
|
||||
@@ -1 +1,3 @@
|
||||
import collections.<warning descr="No module named OrderedDict">OrderedDict</warning>
|
||||
|
||||
collections.OrderedDict()
|
||||
|
||||
@@ -1 +1,3 @@
|
||||
import <error descr="No module named wurm">wurm</error>
|
||||
|
||||
wurm()
|
||||
|
||||
+1
@@ -0,0 +1 @@
|
||||
<warning descr="Unused import statement">import <error descr="No module named spam">spam</error></warning>
|
||||
+1
@@ -0,0 +1 @@
|
||||
<warning descr="Unused import statement">import <error descr="No module named spam">spam</error>.eggs</warning>
|
||||
@@ -28,6 +28,9 @@ public abstract class PyInspectionTestCase extends PyTestCase {
|
||||
configureInspection();
|
||||
}
|
||||
|
||||
protected void doMultiFileTest() {
|
||||
doMultiFileTest("a.py");
|
||||
}
|
||||
protected void doMultiFileTest(@NotNull String filename) {
|
||||
myFixture.copyDirectoryToProject(getTestDirectory(false), "");
|
||||
myFixture.configureFromTempProjectFile(filename);
|
||||
|
||||
+25
@@ -335,6 +335,31 @@ public class PyUnresolvedReferencesInspectionTest extends PyInspectionTestCase {
|
||||
doTest();
|
||||
}
|
||||
|
||||
// PY-6955
|
||||
public void testUnusedUnresolvedModuleImported() {
|
||||
doTest();
|
||||
}
|
||||
|
||||
// PY-6955
|
||||
public void testUnusedUnresolvedNameImported() {
|
||||
doMultiFileTest();
|
||||
}
|
||||
|
||||
// PY-6955
|
||||
public void testUnusedUnresolvedNameImportedSeveralTimes() {
|
||||
doMultiFileTest();
|
||||
}
|
||||
|
||||
// PY-6955
|
||||
public void testUsedUnresolvedNameImportedSeveralTimes() {
|
||||
doMultiFileTest();
|
||||
}
|
||||
|
||||
// PY-6955
|
||||
public void testUnusedUnresolvedPackageImported() {
|
||||
doTest();
|
||||
}
|
||||
|
||||
@NotNull
|
||||
@Override
|
||||
protected Class<? extends PyInspection> getInspectionClass() {
|
||||
|
||||
Reference in New Issue
Block a user