MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-04-19 04:51:24 +07:00
Code Issues Packages Projects Releases Wiki Activity

IDEA-53346 Extra pair of parentheses when completing a constructor call

Browse Source
This commit is contained in:
peter
2010-04-06 15:31:21 +04:00
parent c0a1c3e661
commit d2086dc7f3
4 changed files with 15 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
java/java-impl/src/com/intellij/codeInsight/completion/DefaultInsertHandler.java
View File

@@ -96,6 +96,9 @@ public class DefaultInsertHandler extends TemplateInsertHandler implements Clone
if (completionChar == Lookup.COMPLETE_STATEMENT_SELECT_CHAR) {
tailType = TailType.SMART_COMPLETION;
}
if (myLookupItem.getAttribute(LookupItem.NEW_OBJECT_ATTR) != null && completionChar == '(') {
tailType = TailType.NONE;
}
myState = new InsertHandlerState(myContext.getSelectionEndOffset(), myContext.getSelectionEndOffset());

3
java/java-tests/testData/codeInsight/completion/normal/FinishClassNameWithLParen.java Normal file
View File

@@ -0,0 +1,3 @@
public class Foo {
String s = new Strin<caret>
}

3
java/java-tests/testData/codeInsight/completion/normal/FinishClassNameWithLParen_after.java Normal file
View File

@@ -0,0 +1,3 @@
public class Foo {
String s = new String(<caret>)
}

6
java/java-tests/testSrc/com/intellij/codeInsight/completion/NormalCompletionTest.java
View File

@@ -494,6 +494,12 @@ public class NormalCompletionTest extends LightCompletionTestCase {
checkResultByFile("/codeInsight/completion/normal/" + getTestName(false) + "_after.java");
}
public void testFinishClassNameWithLParen() throws Throwable {
configureByFile("/codeInsight/completion/normal/" + getTestName(false) + ".java");
type('(');
checkResultByFile("/codeInsight/completion/normal/" + getTestName(false) + "_after.java");
}
public void testSelectNoParameterSignature() throws Throwable {
configureByFile("/codeInsight/completion/normal/" + getTestName(false) + ".java");
final int parametersCount = ((PsiMethod)getLookup().getCurrentItem().getObject()).getParameterList().getParametersCount();