MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-03-22 15:19:59 +07:00
Code Issues Packages Projects Releases Wiki Activity

IJPL-28717 Todo line lose coloring

Browse Source 
GitOrigin-RevId: 53eaf4c090bd5d49e201aaee7b4129f7f55bdf9d
This commit is contained in:
Alexey Kudravtsev
2024-07-03 16:26:56 +02:00
committed by intellij-monorepo-bot
parent be3c39b585
commit d0b2cf4fdc
1 changed files with 6 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

29
platform/analysis-impl/src/com/intellij/codeInsight/daemon/impl/TodoHighlightVisitor.java
View File

@@ -4,7 +4,6 @@ package com.intellij.codeInsight.daemon.impl;
import com.intellij.codeInsight.daemon.impl.analysis.HighlightInfoHolder;
import com.intellij.openapi.editor.markup.TextAttributes;
import com.intellij.openapi.progress.ProgressManager;
import com.intellij.openapi.project.Project;
import com.intellij.openapi.util.NlsContexts;
import com.intellij.openapi.util.NlsSafe;
import com.intellij.openapi.util.TextRange;
@@ -22,45 +21,30 @@ import java.util.List;
import java.util.StringJoiner;
final class TodoHighlightVisitor implements HighlightVisitor {
private final Project myProject;
private HighlightInfoHolder myHolder;
TodoHighlightVisitor(@NotNull Project project) {
myProject = project;
}
@Override
public boolean suitableForFile(@NotNull PsiFile file) {
return true;
}
@Override
public boolean analyze(@NotNull PsiFile file,
public boolean analyze(@NotNull PsiFile psiFile,
boolean updateWholeFile,
@NotNull HighlightInfoHolder holder,
@NotNull Runnable action) {
myHolder = holder;
try {
action.run();
}
finally {
myHolder = null;
}
action.run();
// run unconditionally, on the entire file each time, because the todo API sucks and is file-level only
highlightTodos(psiFile, psiFile.getText(), holder);
return true;
}
@Override
public void visit(@NotNull PsiElement element) {
if (element instanceof PsiFile psiFile && psiFile.getViewProvider().getAllFiles().get(0) == psiFile) {
highlightTodos(psiFile, psiFile.getText(), myHolder);
}
}
@SuppressWarnings("CloneDoesntCallSuperClone")
@SuppressWarnings("MethodDoesntCallSuperMethod")
@Override
public @NotNull HighlightVisitor clone() {
return new TodoHighlightVisitor(myProject);
return new TodoHighlightVisitor();
}
private static void highlightTodos(@NotNull PsiFile file,
@@ -122,5 +106,4 @@ final class TodoHighlightVisitor implements HighlightVisitor {
private static boolean shouldHighlightTodos(@NotNull PsiTodoSearchHelper helper, @NotNull PsiFile file) {
return helper instanceof PsiTodoSearchHelperImpl && ((PsiTodoSearchHelperImpl)helper).shouldHighlightInEditor(file);
}
}