MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-27 10:03:11 +07:00
Code Issues Packages Projects Releases Wiki Activity

LocalInspectionsPass: ensure   from html tooltips are escaped in status bar (IDEA-211724)

Browse Source 
GitOrigin-RevId: f454d057943f54e8dccb0735cd860727a0da9c93
This commit is contained in:
Anna Kozlova
2021-01-18 22:24:42 +00:00
committed by intellij-monorepo-bot
parent 0ae5919cf6
commit ce73c3d53d
6 changed files with 12 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
platform/lang-impl/src/com/intellij/codeInsight/daemon/impl/LocalInspectionsPass.java
+4 -1
View File
@@ -572,7 +572,10 @@ public class LocalInspectionsPass extends ProgressableTextEditorHighlightingPass
if (!inspectionProfile.isToolEnabled(key, getFile())) return;
HighlightInfoType type = new InspectionHighlightInfoType(level, element);
final String plainMessage = message.startsWith("<html>") ? StringUtil.unescapeXmlEntities(XmlStringUtil.stripHtml(message).replaceAll("<[^>]*>", "")) : message;
final String plainMessage = message.startsWith("<html>")
? StringUtil.unescapeXmlEntities(XmlStringUtil.stripHtml(message).replaceAll("<[^>]*>", ""))
.replaceAll("&nbsp;", " ")
: message;
@NlsSafe String tooltip = null;
if (descriptor.showTooltip()) {
plugins/devkit/devkit-java-tests/testData/codeInsight/DependsHighlighting.xml
+1 -1
View File
@@ -5,7 +5,7 @@
<depends>com.intellij.modules.vcs</depends>
<depends>com.intellij.custom</depends>
<depends><error descr="Cannot resolve plugin 'com.intellij.xxx' in dependencies&nbsp;(Reference: Plugin Dependencies)">com.intellij.xxx</error></depends>
<depends><error descr="Cannot resolve plugin 'com.intellij.xxx' in dependencies (Reference: Plugin Dependencies)">com.intellij.xxx</error></depends>
<depends <warning descr="Superfluous declaration">optional="false"</warning>>com.intellij.custom3</depends>
plugins/devkit/devkit-java-tests/testData/codeInsight/ExtensionsHighlighting.xml
+1 -1
View File
@@ -72,7 +72,7 @@
<indirect.indirect/>
<<error descr="Cannot resolve extension point 'com.intellij.custom.error' in dependencies&nbsp;(Reference: Plugin Dependencies)">custom.error</error>
<<error descr="Cannot resolve extension point 'com.intellij.custom.error' in dependencies (Reference: Plugin Dependencies)">custom.error</error>
<error descr="Attribute customAttribute is not allowed here">customAttribute</error>=""/>
<<error descr="Missing dependency declaration for using extension point 'com.intellij.notincluded.notInDependencies'">notincluded.notInDependencies</error>/>
plugins/devkit/devkit-java-tests/testData/codeInsight/pluginWithXInclude.xml
+1 -1
View File
@@ -15,7 +15,7 @@
<bar implementation="java.util.ArrayList"/>
<extensionX/>
<extension2/>
<<error descr="Cannot resolve extension point 'foo.extensionUnknown' in dependencies&nbsp;(Reference: Plugin Dependencies)">extensionUnknown</error>/>
<<error descr="Cannot resolve extension point 'foo.extensionUnknown' in dependencies (Reference: Plugin Dependencies)">extensionUnknown</error>/>
</extensions>
<xi:include href="<error descr="Cannot resolve file 'INVALID_VALUE.xml'">INVALID_VALUE.xml</error>"/>
plugins/devkit/devkit-java-tests/testData/codeInsight/pluginXmlDynamicPluginInspection/pluginXmlDynamicPluginInspection-highlighting.xml
+3 -3
View File
@@ -24,13 +24,13 @@
</actions>
<<warning descr="Non-dynamic plugin due to using components.&nbsp;Migration Guide">application-components</warning>>
<<warning descr="Non-dynamic plugin due to using components. Migration Guide">application-components</warning>>
</application-components>
<<warning descr="Non-dynamic plugin due to using components.&nbsp;Migration Guide">project-components</warning>>
<<warning descr="Non-dynamic plugin due to using components. Migration Guide">project-components</warning>>
</project-components>
<<warning descr="Non-dynamic plugin due to using components.&nbsp;Migration Guide">module-components</warning>>
<<warning descr="Non-dynamic plugin due to using components. Migration Guide">module-components</warning>>
</module-components>
</idea-plugin>
plugins/java-i18n/testData/inspections/duplicateStringLiteral/PropertyKey.java
+2 -2
View File
@@ -3,11 +3,11 @@ import org.jetbrains.annotations.*;
@SuppressWarnings({"HardCodedStringLiteral"})
class Test {
@SuppressWarnings({"HardCodedStringLiteral"})
String s = <warning descr="Duplicate string literal found in&nbsp;&nbsp;&nbsp;'Test' (in this file)">"abcdefghhijklmnop"</warning>;
String s = <warning descr="Duplicate string literal found in 'Test' (in this file)">"abcdefghhijklmnop"</warning>;
@SuppressWarnings({"HardCodedStringLiteral"})
void f(@PropertyKey(resourceBundle = "xxx.yyy") String key) {
String s = <warning descr="Duplicate string literal found in&nbsp;&nbsp;&nbsp;'Test' (in this file)">"abcdefghhijklmnop"</warning>;
String s = <warning descr="Duplicate string literal found in 'Test' (in this file)">"abcdefghhijklmnop"</warning>;
f("abcdefghhijklmnop"); //no way
}
}